wayland: Fix wingpanel breaking everything #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yeah this has to do with setting the panel size/struts when styles change between transparent and translucent. It might be an X specific issue |
danirabbit
reviewed
Apr 3, 2024
| @@ -81,8 +81,6 @@ public class Wingpanel.PanelWindow : Gtk.Window { | |||
|
|
|||
| key_controller = new Gtk.EventControllerKey (this); | |||
| key_controller.key_pressed.connect (on_key_pressed); | |||
|
|
|||
| panel.size_allocate.connect (update_panel_dimensions); | |||
There was a problem hiding this comment.
Maybe instead for now we do this?
if (!Utils.is_wayland ()) {
panel.size_allocate.connect (update_panel_dimensions);
}
There was a problem hiding this comment.
@danirabbit sure that works, sorry kinda forgot about this PR 😬
Updated it :)
danirabbit
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
I've got no idea what's going on here but this small line of code broke pretty much everything on wayland (See the linked issue and its comment). The only workaround currently is killing wingpanel first thing you do when getting into the wayland session before touching anything else.
@danirabbit this was added recently with #493. Everything still works fine for me without it but I didn't test a lot so maybe you can give some background on why it was added?