Make an identifier for the select2 customization. Fixes #4325

elementor · May 8, 2018 · 58a93c9 · 58a93c9 · obe1968 · May 8, 2018
1 parent 8424d03
commit 58a93c9
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 12 deletions.
diff --git a/assets/lib/select2/css/select2.css → assets/lib/e-select2/css/e-select2.css b/assets/lib/select2/css/select2.css → assets/lib/e-select2/css/e-select2.css
diff --git a/assets/lib/select2/css/select2.min.css → assets/lib/e-select2/css/e-select2.min.css b/assets/lib/select2/css/select2.min.css → assets/lib/e-select2/css/e-select2.min.css
diff --git a/assets/lib/select2/js/select2.full.js → assets/lib/e-select2/js/e-select2.full.js b/assets/lib/select2/js/select2.full.js → assets/lib/e-select2/js/e-select2.full.js
@@ -2,6 +2,8 @@
  * Select2 4.0.6-rc.1
  * https://select2.github.io
  *
+ * With a fix by Elementor team at line 4329
+ *
  * Released under the MIT license
  * https://github.com/select2/select2/blob/master/LICENSE.md
  */
@@ -4324,8 +4326,7 @@ S2.define('select2/dropdown/attachBody',[
     });
 
     $watchers.on(scrollEvent, function (ev) {
-      var position = Utils.GetData(this, 'select2-scroll-position');
-      $(this).scrollTop(position.y);
+	    self._positionDropdown();
     });
 
     $(window).on(scrollEvent + ' ' + resizeEvent + ' ' + orientationEvent,

diff --git a/assets/lib/select2/js/select2.full.min.js → ...ts/lib/e-select2/js/e-select2.full.min.js b/assets/lib/select2/js/select2.full.min.js → ...ts/lib/e-select2/js/e-select2.full.min.js
diff --git a/includes/editor.php b/includes/editor.php
@@ -385,8 +385,8 @@ public function enqueue_scripts() {
 		);
 
 		wp_register_script(
-			'jquery-select2',
-			ELEMENTOR_ASSETS_URL . 'lib/select2/js/select2.full' . $suffix . '.js',
+			'jquery-elementor-select2',
+			ELEMENTOR_ASSETS_URL . 'lib/e-select2/js/e-select2.full' . $suffix . '.js',
 			[
 				'jquery',
 			],
@@ -454,7 +454,7 @@ public function enqueue_scripts() {
 				'tipsy',
 				'imagesloaded',
 				'heartbeat',
-				'jquery-select2',
+				'jquery-elementor-select2',
 				'flatpickr',
 				'elementor-dialog',
 				'ace',
@@ -736,8 +736,8 @@ public function enqueue_styles() {
 		);
 
 		wp_register_style(
-			'select2',
-			ELEMENTOR_ASSETS_URL . 'lib/select2/css/select2' . $suffix . '.css',
+			'elementor-select2',
+			ELEMENTOR_ASSETS_URL . 'lib/e-select2/css/e-select2' . $suffix . '.css',
 			[],
 			'4.0.5'
 		);
@@ -768,7 +768,7 @@ public function enqueue_styles() {
 			ELEMENTOR_ASSETS_URL . 'css/editor' . $direction_suffix . $suffix . '.css',
 			[
 				'font-awesome',
-				'select2',
+				'elementor-select2',
 				'elementor-icons',
 				'wp-auth-check',
 				'google-font-roboto',

diff --git a/includes/preview.php b/includes/preview.php
@@ -170,8 +170,8 @@ private function enqueue_styles() {
 		$direction_suffix = is_rtl() ? '-rtl' : '';
 
 		wp_register_style(
-			'select2',
-			ELEMENTOR_ASSETS_URL . 'lib/select2/css/select2' . $suffix . '.css',
+			'elementor-select2',
+			ELEMENTOR_ASSETS_URL . 'lib/e-select2/css/e-select2' . $suffix . '.css',
 			[],
 			'4.0.5'
 		);
@@ -180,7 +180,7 @@ private function enqueue_styles() {
 			'editor-preview',
 			ELEMENTOR_ASSETS_URL . 'css/editor-preview' . $direction_suffix . $suffix . '.css',
 			[
-				'select2',
+				'elementor-select2',
 			],
 			ELEMENTOR_VERSION
 		);

diff --git a/tests/test-editor.php b/tests/test-editor.php
@@ -53,7 +53,7 @@ public function test_enqueueStyles() {
 
 		$styles = [
 			'font-awesome',
-			'select2',
+			'elementor-select2',
 			'elementor-icons',
 			'wp-auth-check',
 			'google-font-roboto',