-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悶 Style Guide throws a JS error in the frontend: e.0 is not a function #24492
Comments
Happens on every single page. Please fix together with #19345 |
Any Updates? In new version can't even deactivate |
@askwpgirl The title is correct based on what the script is doing. Please do not submit duplicates of the same issue. |
Is there any movement on this bug? We cannot deliver client sites using Elementor that: a) Look like page updates aren't saving and b) roll back the plugin and then deliver sites that aren't up to date. This is making my move over to Breakdance Builder much more urgent! |
@askwpgirl the issue is caused by the Style Guide component, whether you agree with it or not. The title of the issue follows an internal pattern created to be easily recognized not only by the public, but by our team of engineers as well. What decides if a title is right or wrong, is the component that the issue affects. Despite showing an error in the console, this issue does not affect the functionality of Elementor on the front-end, neither in the backend. When this issue was reported, the Style Guide was still an experimental feature that could be turned off. Now, the Style Guide was merged to Core not long ago, and this is why this error appears in the console. I am well aware of what is the origin of the issue, how to reproduce it, and how it can possibly be solved. We appreciate the effort to communicate and report issues. We will fix it as soon as other (more pressing) tasks are resolved. Kind regards |
@nicholaszein - Thank you for explaining how this is a now part of core and that the Setting in the description does not exist any longer. My suggestion for updating the description to reflect latest Elementor was to clear up confusion for users like me reading this going forward. But I honestly don't know how this is best handled due to GitHub and dates submitted, so I defer to you. Yes, it does not appear to be effecting the functionality and is not a pressing issue. Please know I appreciate all of your work! I am only trying to help with people like me who got confused due to this being part of core now and no longer being in Settings. I deleted my other comment since your explanation cleared things up, and it makes sense now. |
@askwpgirl - The error does not affect the page actually saving but when closing the page it says that there are unsaved changes... I cannot present this stuff to my clients. Perhaps we can stop arguing over the title semantics and ensure that the error is fixed. |
Thank you @CodeConnectPtyLtd. |
edit: The js error reported in the original post does not appear to be related to the Update button not working. Those are two different issues, with the update issue likely being related to Rank Math and not Elementor. See responses below. I have been experiencing this issue on more and more websites over the past week. I don't even have a Global Style Guide option to enable/disable, so I'm not able to apply any kind of temporary fix. With clients asking to make their own edits, I'm not very happy handing over control if the editor isn't working as it should.
I'm getting the same issues as reported by others: The Update button is always active, and pressing it doesn't make it inactive. Leaving the page shows the 'are you sure you want..' pop-up, implying my changes didn't get saved (when they did). I created a staging copy and disabled all plugins other than Elementor and Elementor Pro, and the issue went away. I enabled each plugin one at a time and discovered that enabling Rank Math brought the issue back. Disabling it, the issue went away again. However, while the button issue is resolved, the same error is thrown in the console. I re-enabled Rank Math and disabled each feature before narrowing it down to Titles & Meta -> Pages, and disabling Add SEO Controls. For whatever reason, disabling this brought back normal 'Update' functionality when editing pages. However, the same error persists in the dev console, so I'm not sure what's that all about. In any case, if anyone happens to be experiencing this issue and also have Rank Math installed, try going to Titles & Meta -> Pages, and disabling Add SEO Controls. This has fixed the issue on two of my websites so far. |
@ev88 - Please read Nicholas' comment above about how there is no setting for this now that it is in core. Also, to be clear, this error is minor and does NOT affect ANY functionality. If you are experiencing functional issues then in all likelihood it is not related to this. |
@askwpgirl, and @ev88. The issue reported with the update button has absolutely nothing to do with this issue. It's a known bug caused by Rank Math, which I believe is set to release a fix in the next week. @ev88, the problem you're reporting is caused by the Rank Math plugin, and has nothing to do with this issue. Please reach out to Rank Math support. The triaging process, titles, and labeling of issues, and other processes performed by Elementor staff on GitHub are not open for discussion. I even updated the title to include the line of error that appears in the console to help you, but this doesn't give you permission to dictate how an issue should be handled. Please, respect our process. |
@askwpgirl True, I guess CodeConnectPtyLtd's comment made me think the two issues were related (a Google search led me here). So the original js error shown in the console does not appear to have been related to the Update button not working, and not really relevant to this issue. But yes, the js error itself should be looked into regardless. edit: @nicholaszein Bleh, you were too quick for me. :) |
The issue will remain they way it is, unless we need to change something. This matter is closed. We appreciate the feedback. |
@ev88 - correct. It is not an urgent issue and not causing problems. I also inadvertently found the error trying to troubleshoot another issue. Lots of people having issues related to different problems might stumble upon this error and assume it is the source of their problems. So far, I am not seeing it causing any real functionality issues as it happens on every Elementor site. @nicholaszein - thank you! No problem. |
So its just going to stay broken? |
@nicholaszein |
@ColbyDevOps yes, because it doesn't affect anything in terms of functionality or stability. It's just a console error that only appears in edge cases. Having a way to disable it, was never in the plans for this feature. |
I've created a short screen recording to demonstrate that the issue is actually affecting the user interface and therefore usability. Please take 1.5 minutes to view the screen recording below: |
There is a RankMath beta release that actually fixes the UI issue that prevents closing the window. https://support.rankmath.com/ticket/conflict-with-elementor-10/ |
@CodeConnectPtyLtd, the Update button issue is caused by a bug in the Rank Math plugin, and has absolutely nothing to do with this one, as stated multiple times here, here, here, and here. And, as you already saw for yourself here. |
@ColbyDevOps nobody said it was going to stay broken. The "matter" in this case was the unnecessary discussion about the title and description of this issue. The issue is not closed. It will be closed when we address it. But it isn't a priority right now. We are going to handle it most likely in the next quarter. I can also edit images just fine, so it doesn't affect image controls at all. If you are having trouble with those, it's something else entirely, and likely a conflict caused by another plugin. |
This is a really annoying error, especially if you want to do some error catching for the whole site to be informed if something is going wrong in JavaScript. Why it is not fixed after reporting over 6 month ago... |
Prerequisites
Description
When Global Style Guide is enabled in Elementor > Settings > Features I get an error in dev console in a fresh created page with no content.
When I disable Global Style Guide the error goes away.
Steps to reproduce
Enable Global Style Guide
Create a new page.
Isolating the problem
System Info
Click to reveal
The text was updated successfully, but these errors were encountered: