Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: accessible widget search #2835

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Nov 27, 2017

The widget search is not accessible. It should either use role="search" or type="search".

In addition, the input field should have a label for screen readers. We hide the label for regular users using class="screen-reader-text", this way only screen readers "see" it.

Ref: https://www.w3.org/TR/html-aria/

elementor-widget-search

@ramiy
Copy link
Contributor Author

ramiy commented Nov 27, 2017

@arielk Please review the PR.

@ramiy
Copy link
Contributor Author

ramiy commented Nov 27, 2017

@kobizz, @matipojo, @joshmarom

on the same principle, when we define Controls with 'show_label' => false argument, the Label should not be removed, it should have class="screen-reader-text". This way screen readers "see" it but normal users don't.

@KingYes KingYes merged commit 45f826f into elementor:release/1.9.0 Nov 27, 2017
@ramiy ramiy deleted the accessibility branch November 29, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants