Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After 2.6 update Star icon appears where Icon Box is used #8596

Closed
2 tasks done
sushmak02 opened this issue Jul 17, 2019 · 6 comments
Closed
2 tasks done

After 2.6 update Star icon appears where Icon Box is used #8596

sushmak02 opened this issue Jul 17, 2019 · 6 comments

Comments

@sushmak02
Copy link

sushmak02 commented Jul 17, 2019

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

On my site, I have used the Iconbox widget. The icon is unset.

With Elementor version 2.5.16 - https://cl.ly/f489a48a2d41

After the Elementor 2.6.2 update, the star icon is added to all the icon boxes on my website.
Refer this screenshot - https://cl.ly/08ad2293c00b

This is changed on all my websites. How can I fix this?

Steps to reproduce

  • Add an Icon box on your page with Elementor 2.5.16 version.
  • Remove the icon from Select icon selection - https://cl.ly/f489a48a2d41
  • Upgrade to Elementor latest version.
  • Check the IconBox on your page.
  • The default Star icon appears in the Icon Box.
@ahemads
Copy link

ahemads commented Jul 17, 2019

I am facing the same issue.

@sushmak02
Copy link
Author

@bainternet Any update on this issue? Are you planning to fix it?

@shilo-ey
Copy link
Contributor

shilo-ey commented Jul 22, 2019

Thanks for reporting. this issue will be addressed soon a patch version.

@shilo-ey
Copy link
Contributor

This issue has been resolved in Elementor v2.6.6

Feel free to update

Thanks!

@sushmak02
Copy link
Author

Hey @shilo-ey,

The above issue seems to be fixed only at the backend editor of Elementor.

In the above case, with your fix, the Star icon does not display in the output and fixes the issue.

But, when I try to set a new icon it does not display at the frontend. It appears correctly in the backend.

I tried to debug your code and seems like the $migrated variable always returns false in the render() even if the icon is changed.
$migrated = isset( $settings['__fa4_migrated']['selected_icon'] );

Can you please look into this and fix this ASAP?

@sushmak02
Copy link
Author

Here is a screencast of the same - https://cl.ly/6bf906b09845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants