Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Icons: Is LinkedIn Official Color Gray Now? #9298

Closed
5 tasks done
black-eye opened this issue Oct 9, 2019 · 1 comment
Closed
5 tasks done

Social Icons: Is LinkedIn Official Color Gray Now? #9298

black-eye opened this issue Oct 9, 2019 · 1 comment
Labels
control/icons References any instance of the Icon control. status/merged Indicates when a Pull Request has been merged to a Release.

Comments

@black-eye
Copy link

black-eye commented Oct 9, 2019 •
edited
Loading

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

The color for LinkedIn social icon has changed after update from 2.5 to 2.7.
Before:
obrazek

After:
obrazek

Is it an intention or a bug? Has LinkedIn changed their official color?

Steps to reproduce

  1. Insert Social Icon in Elementor version earlier than 2.6 and select LinkedIn
  2. Update to the latest version of Elementor
  3. Update FontAwesome (not sure if necessary, but what has been done, cannot be undone)
  4. Open the page with Social Icons widget for editing
  5. Click on the Social Icon widget --> the color of LinkedIn instantly turns from blue to gray.

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a default WordPress theme active.
  • I can reproduce this bug consistently using the steps above.

Environment

System Info ```

== Server Environment ==
Operating System: Linux
Software: Apache/2.4.10 (Debian)
MySQL version: (Debian) v5.5.60
PHP Version: 7.2.8-1+020180725113345.2+jessie1.gbp571e56
PHP Max Input Vars: 1000
PHP Max Post Size: 8M
GD Installed: Yes
ZIP Installed: Yes
Write Permissions: All right
Elementor Library: Connected

== WordPress Environment ==
Version: 5.2.3
Site URL: http://demo.remedical.cz
Home URL: http://demo.remedical.cz
WP Multisite: No
Max Upload Size: 8 MB
Memory limit: 256M
Permalink Structure: /%postname%/
Language: cs-CZ
Timezone: Europe/Prague
Debug Mode: Inactive

== Theme ==
Name: Remedical WPBF
Version: 1.0.0
Author: Petr Jandák
Child Theme: Yes
Parent Theme Name: Page Builder Framework
Parent Theme Version: 2.0.4
Parent Theme Author: David Vongries

== User ==
Role: administrator
WP Profile lang: cs_CZ
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

== Active Plugins ==
ACF Content Analysis for Yoast SEO
Version: 2.3.0
Author: Thomas Kräftner, ViktorFroberg, marol87, pekz0r, angrycreative, Team Yoast

Activity Log
	Version: 2.5.2
	Author: Activity Log Team

Admin Menu Editor
	Version: 1.9.1
	Author: Janis Elsts

Advanced Custom Fields PRO
	Version: 5.8.5
	Author: Elliot Condon

All-in-One WP Migration
	Version: 6.77
	Author: ServMask

Caldera Forms
	Version: 1.7.6
	Author: Caldera Labs

Central Color Palette
	Version: 1.13.11
	Author: Daniel Schneider

Classic Editor
	Version: 1.5
	Author: WordPress Contributors

Clean Image Filenames
	Version: 1.2.1
	Author: Upperdog

Cookie Notice
	Version: 1.2.46
	Author: dFactory

Cyr-To-Lat
	Version: 4.2.3
	Author: Sergey Biryukov, Mikhail Kobzarev, Igor Gergel

Disable Comments
	Version: 1.10.2
	Author: Samir Shah

Duplicate Post
	Version: 3.2.3
	Author: Enrico Battocchi

Elementor
	Version: 2.7.4
	Author: Elementor.com

Elementor Extras
	Version: 2.2.5
	Author: Namogo

Elementor Pro
	Version: 2.7.2
	Author: Elementor.com

Intuitive Custom Post Order
	Version: 3.1.2
	Author: hijiri

iThemes Security
	Version: 7.4.1
	Author: iThemes

Lightbox with PhotoSwipe
	Version: 2.8
	Author: Arno Welzel

Page Builder Framework Premium Addon
	Version: 2.0.3
	Author: David Vongries

Page scroll to id
	Version: 1.6.3
	Author: malihu

Polylang
	Version: 2.6.4
	Author: WP SYNTEX

Polylang - Translate URL Rewrite Slugs
	Version: 0.3.6
	Author: KLicheR

Polylang Connect for Elementor
	Version: 1.0.0
	Author: David Decker - DECKERWEB

ShortPixel Image Optimizer
	Version: 4.14.5
	Author: ShortPixel

Simple 301 Redirects
	Version: 1.07
	Author: Scott Nellé

SVG Support
	Version: 2.3.15
	Author: Benbodhi

TinyMCE Advanced
	Version: 5.2.1
	Author: Andrew Ozz

WP Media folder
	Version: 4.9.2
	Author: Joomunited

Yoast SEO
	Version: 12.2
	Author: Team Yoast

Zalomení
	Version: 1.4.7
	Author: Honza Skypala

== LogClear Log ==

JS: showing 2 of 2JS: 2019-02-11 13:32:33 [error X 1][http://demo.remedical.cz/wp-content/plugins/elementor/assets/js/editor.min.js?ver=2.4.5:2:209381] Cannot read property 'on' of null
JS: 2019-02-13 22:15:40 [error X 8][http://demo.remedical.cz/wp-content/plugins/elementor/assets/js/editor.min.js?ver=2.4.6:2:74603] setting getter-only property "type"

Log: showing 20 of 402019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_posts Finished
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_portfolio Start
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_portfolio Finished
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_products Start
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_products Finished
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_form Start
2019-05-16 13:29:48 [info] Elementor Pro/Upgrades - _v_2_5_4_form Finished
2019-05-16 13:29:48 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '2.4.4',
'to' => '2.5.8',
)]
2019-10-09 01:21:30 [info] elementor::elementor_updater Started
2019-10-09 01:21:30 [info] Elementor/Upgrades - _v_2_6_0_fa4_migration_flag Start
2019-10-09 01:21:30 [info] Elementor/Upgrades - _v_2_6_0_fa4_migration_flag Finished
2019-10-09 01:21:30 [info] Elementor/Upgrades - _v_2_6_6_fa4_migration_button Start
2019-10-09 01:21:31 [info] Elementor/Upgrades - _v_2_6_6_fa4_migration_button Finished
2019-10-09 01:21:31 [info] Elementor/Upgrades - _v_2_7_1_remove_old_usage_data Start
2019-10-09 01:21:31 [info] Elementor/Upgrades - _v_2_7_1_remove_old_usage_data Finished
2019-10-09 01:21:31 [info] Elementor/Upgrades - _v_2_7_1_recalc_usage_data Start
2019-10-09 01:21:31 [info] Elementor/Upgrades - _v_2_7_1_recalc_usage_data Finished
2019-10-09 01:21:31 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor',
'from' => '2.5.15',
'to' => '2.7.4',
)]
2019-10-09 01:21:31 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor',
'from' => '2.5.15',
'to' => '2.7.4',
)]
2019-10-09 01:22:04 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '2.5.8',
'to' => '2.7.2',
)]

PHP: showing 1 of 1PHP: 2019-10-09 01:23:56 [notice X 1][/web/demo.remedical.cz/wp-content/plugins/elementor-pro/modules/query-control/module.php::360] Undefined index: q [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]

== Elements Usage ==

archive
	heading : 4
	icon-list : 1
	shortcode : 3
	text-editor : 1
	theme-archive-title : 1
footer
	ee-inline-svg : 1
	heading : 3
	social-icons : 1
	text-editor : 4
page
	heading : 1
	post-info : 1
	post-navigation : 1
	share-buttons : 1
	shortcode : 2
	social-icons : 1
	theme-post-content : 1
	theme-post-title : 1
section
	button : 1
	counter : 4
	heading : 5
	image-box : 4
single
	heading : 3
	post-info : 1
	post-navigation : 2
	share-buttons : 2
	shortcode : 2
	text-editor : 1
	theme-post-content : 3
	theme-post-title : 2
wp-post
	button : 4
	button-group : 9
	counter : 8
	gallery-extra : 2
	google_maps : 2
	heading : 121
	hotspots : 4
	html : 2
	image : 42
	image-box : 7
	posts-extra : 2
	shortcode : 7
	social-icons : 2
	template : 7
	text-editor : 46
	wp-widget-malihupagescroll2idwidget : 31

			```
@shilo-ey
Copy link
Contributor

The icon name is changed to linkedin-in, we need to add support for this one too :)

Thanks, we will update this soon

@shilo-ey shilo-ey added control/icons References any instance of the Icon control. status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Oct 10, 2019
KingYes added a commit that referenced this issue Oct 10, 2019
@KingYes
Merge pull request #9307 from shilo-ey/fix/i-9298
43c1f96 
Fix: Added official color support for `linkedin-in` icon in Social Icons widget closes #9298
@shilo-ey shilo-ey added status/merged Indicates when a Pull Request has been merged to a Release. and removed status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
control/icons References any instance of the Icon control. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black-eye @shilo-ey