Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps accessibility - iFrame title missing #9955

Closed
2 tasks done
cydfer opened this issue Dec 21, 2019 · 1 comment
Closed
2 tasks done

Google Maps accessibility - iFrame title missing #9955

cydfer opened this issue Dec 21, 2019 · 1 comment
Labels
status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. type/accessibility Indicates when a topic is related to Accessibility.

Comments

@cydfer
Copy link

cydfer commented Dec 21, 2019

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.
Similar to #9374, the Google Maps iFrame does not have the option to include a title attribute. I added an attribute for an ARIA label, but apparently that's not enough to keep from getting the "missing title in iframe" flag in accessibility testers.

Describe the solution you'd like
Please either automatically add a title attribute, or allow us to enter one in a field.

Describe alternatives you've considered
I thought about using an HTML widget to recreate the iframe, but that would be reinventing the wheel (abandoning the nice map functionality Elementor provided). I realized it couldn't be fixed with CSS and didn't see a way to use the attributes section under Advanced to create one.

@arielk arielk added type/accessibility Indicates when a topic is related to Accessibility. status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Aug 23, 2020
KingYes added a commit that referenced this issue Sep 3, 2020
Add iFrame title for Google Maps widget - fix #9955
@KingYes KingYes closed this as completed in bbb00ac Sep 6, 2020
@shilo-ey
Copy link
Contributor

shilo-ey commented Sep 6, 2020

This issue has been resolved in Elementor v3.0.6

Feel free to update

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. type/accessibility Indicates when a topic is related to Accessibility.
Projects
None yet
Development

No branches or pull requests

3 participants