Internal: Updated Font Awesome library to v6 [ED-12569] #24315
+35,681
−2,966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2569-fontawesome6
…nto ED-12569-fontawesome6
…nto ED-12569-fontawesome6
rotemee
requested changes
Feb 13, 2024
rotemee
reviewed
Feb 14, 2024
ManorHazaz
reviewed
Feb 15, 2024
includes/plugin.php
Outdated
| @@ -720,6 +732,7 @@ private function init_components() { | |||
| $this->files_manager = new Files_Manager(); | |||
| $this->assets_manager = new Assets_Manager(); | |||
| $this->icons_manager = new Icons_Manager(); | |||
| $this->icons_migrations = new Icons_Migrations(); | |||
There was a problem hiding this comment.
Maybe it should be inside the icons manager?
includes/widgets/icon-list.php
Outdated
| @@ -169,14 +170,14 @@ protected function register_controls() { | |||
| [ | |||
| 'text' => esc_html__( 'List Item #2', 'elementor' ), | |||
| 'selected_icon' => [ | |||
| 'value' => 'fas fa-times', | |||
| 'value' => 'fas ' . ( Icons_Migrations::is_migration_required() ? 'fa-times' : 'fa-xmark' ), | |||
There was a problem hiding this comment.
I don't like the fact that it's all over the widgets...
…nto ED-12569-fontawesome6
…ntor/elementor into ED-12569-fontawesome6
|
Sorry to bother, but any updates on this? @mark-elementor |
|
@rotemee @ManorHazaz @hein-obox @Omerisra6 @mark-elementor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #