Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the playsinline attribute to background videos #8199

Merged
merged 1 commit into from
May 30, 2019

Conversation

Pikamander2
Copy link
Contributor

@Pikamander2 Pikamander2 commented May 26, 2019

Add the playsinline attribute to background videos so that they'll correctly autoplay on iOS

See here for more details about Apple's requirements: https://webkit.org/blog/6784/new-video-policies-for-ios/

Fixes #8198 and #3442

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

Add the playsinline attribute to background videos that they'll correctly autoplay on iOS

See here for more details about Apple's requirements: https://webkit.org/blog/6784/new-video-policies-for-ios/
@CLAassistant
Copy link

CLAassistant commented May 26, 2019

CLA assistant check
All committers have signed the CLA.

@KingYes KingYes changed the base branch from master to release/2.6.0 May 29, 2019 15:34
@KingYes KingYes merged commit 4dcc16e into elementor:release/2.6.0 May 30, 2019
@KingYes
Copy link
Member

KingYes commented May 30, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants