Correctly map card references in series

elevate · Aug 1, 2018 · 02bf717 · 02bf717
1 parent dcca4c8
commit 02bf717
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 1 deletion.
diff --git a/metabase-exporter/ApiObjects.cs b/metabase-exporter/ApiObjects.cs
@@ -210,7 +210,37 @@ public class DashboardCard
         public JObject VisualizationSettings { get; set; }
 
         [JsonProperty("series")]
-        public object[] Series { get; set; }
+        public DashboardSeriesCard[] Series { get; set; }
+    }
+
+    /// <summary>
+    /// A reference to a <see cref="Card"/> in a series (i.e. 2 or more overlapped graphs) in a dashboard.
+    /// </summary>
+    public class DashboardSeriesCard
+    {
+        /// <summary>
+        /// References <see cref="Card.Id"/>
+        /// </summary>
+        [JsonProperty("id")]
+        public int Id { get; set; }
+
+        [JsonProperty("description")]
+        public string Description { get; set; }
+
+        [JsonProperty("collection_id")]
+        public int? CollectionId { get; set; }
+
+        [JsonProperty("name")]
+        public string Name { get; set; }
+
+        [JsonProperty("display")]
+        public string Display { get; set; }
+
+        [JsonProperty("dataset_query")]
+        public DatasetQuery DatasetQuery { get; set; }
+
+        [JsonProperty("visualization_settings")]
+        public JObject VisualizationSettings { get; set; } // ?
     }
 
     /// <summary>

diff --git a/metabase-exporter/MetabaseApiExport.cs b/metabase-exporter/MetabaseApiExport.cs
@@ -45,6 +45,11 @@ public static async Task<MetabaseState> Export(this MetabaseApi api)
                     {
                         parameter.CardId = cardMapping[parameter.CardId];
                     }
+
+                    foreach (var seriesCard in card.Series)
+                    {
+                        seriesCard.Id = cardMapping[seriesCard.Id];
+                    }
                 }
             }
 

diff --git a/metabase-exporter/MetabaseApiImport.cs b/metabase-exporter/MetabaseApiImport.cs
@@ -126,6 +126,14 @@ static IEnumerable<DashboardCard> MapDashboardCards(IEnumerable<DashboardCard> s
                         .Select(x => x.Target)
                         .First();
                 }
+
+                foreach (var s in card.Series)
+                {
+                    s.Id = cardMapping
+                        .Where(x => x.Source == s.Id)
+                        .Select(x => x.Target)
+                        .First();
+                }
                 yield return card;
             }
         }