Sync trakt lists even if Kodi library integration is disabled #97
Conversation
| @@ -1161,11 +1177,6 @@ func SyncShowsList(listID string, updating bool, isUpdateNeeded bool) (err error | |||
| removedShows = DiffTraktShows(current, previous, IsTraktInitialized) | |||
| } | |||
|
|
|||
| if err != nil { | |||
There was a problem hiding this comment.
probably leftovers from previous code.
| @@ -1049,11 +1063,6 @@ func SyncMoviesList(listID string, updating bool, isUpdateNeeded bool) (err erro | |||
| removedMovies = DiffTraktMovies(current, previous, IsTraktInitialized) | |||
| } | |||
|
|
|||
| if err != nil { | |||
There was a problem hiding this comment.
probably leftovers from previous code.
|
user confirmed that everything works now as expected elgatito/plugin.video.elementum#680 (comment) |
| @@ -648,7 +648,7 @@ func updateShowWatched(xbmcHost *xbmc.XBMCHost, s *trakt.WatchedShow, watched bo | |||
|
|
|||
| // RefreshTraktCollected ... | |||
| func RefreshTraktCollected(xbmcHost *xbmc.XBMCHost, itemType int, isRefreshNeeded bool) error { | |||
| if config.Get().TraktToken == "" || !config.Get().TraktSyncCollections { | |||
| if config.Get().TraktToken == "" { | |||
There was a problem hiding this comment.
What is the idea of removing the use of a setting that was added for this case?
That was the only place for those properties TraktSyncCollections, TraktSyncWatchlist, TraktSyncUserlists?
Idea was to disable sync for specific parts instead of disabling whole sync.
There was a problem hiding this comment.
Those settings are not removed, but moved inside functions that actually does trakt update. So we can do update of trakt and then if needed - also do kodi library update. But maybe it makes sense to split those functions completely.
|
|
||
| // FIXME: should it be like for shows - 'if !updating && !isUpdateNeeded && IsDuplicateShow(tmdbID) {' ? | ||
| if uid.IsDuplicateMovie(tmdbID) { | ||
| if !updating && !isUpdateNeeded && uid.IsDuplicateMovie(tmdbID) { |
There was a problem hiding this comment.
if uid.IsDuplicateMovie(tmdbID)
This should probably always be in a separate block to have a check for duplicates for any method arguments.
There was a problem hiding this comment.
@elgatito заметил, что в новом коде IsDuplicateMovie не отделено в отдельный блок и для фильмов и для сериалов. забыл или решил что отдельный блок не нужен?
|
I guess the idea was to still get and cache different lists even if lists sync is disabled to properly show list of Shows in My Collection or lists. But you will still need a dependency to have Trakt Sync enabled (global sync) to update lists. And there is another request to split I will use part of code from this PR and split actions. |
|
I have pushed a change using partly this code. |
right now if we disable settings like "Sync items from ... into Kodi library" then we do not update data about collection/watchlist/userlists anymore, thus even in internal elementum menus we see old data for those lists.
fixes elgatito/plugin.video.elementum#680