Add rule to named return parameters and add config option to check Stutter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elgris
added a commit
that referenced
this pull request
Jun 22, 2015
Add rule to named return parameters and add config option to check Stutter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
There are two additions: taken out variable settings for checking the names of variables, if they begin with the name of the package; and added a check on the use of named return values. I think that this test should be added, because when you use named parameters, you can create very difficult to perceptible errors when, by mistake or misspelling, use "=" instead of "=" - thus there will be shadowing variables and will not give any error, because the returned variable is already initialized.