feat: add concurrency for list #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| list += getField(" Code", s.Code.Content) | ||
| } | ||
| list += "\n" | ||
| go sprintScript(&wg, output, i, s, isCode, isSolution) |
There was a problem hiding this comment.
interesting, didn't knew we can do such improvements With Concurency 👌🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves considerably the speed of the list command
Why ?
On big files ( > 4mb) the list command was taking almost 50 minutes to run, we wanted to bring it down to a reasonable time. And now it runs bellow 2s
How ?
To improve the command speed, the reformat of the file content is now done concurrently.
Steps to verify:
To test that it runs now bellow 2s run
time ./ckp f --from-history --allScreenshots (optional)
BEFORE
AFTER