Error fixed when image is missing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,4 +6,10 @@ | |||
| tag.should match('height="64"') | |||
| tag.should match('width="50"') | |||
| end | |||
|
|
|||
| it "should not return no image or error if the image is missing" do | |||
There was a problem hiding this comment.
"should" in the example description is no longer a good practice I would reword it as
it "works with missing images"
There was a problem hiding this comment.
Whoops didn't know
|
New commit added ;) |
| @@ -15,8 +15,9 @@ module Helper | |||
| # | |||
| def image_tag source, options = {} | |||
| unless options[:size] | |||
| fs_path = asset_paths.asset_for(source, nil).to_path | |||
| options[:width], options[:height] = ::Dimensions.dimensions(fs_path) | |||
| fs_path = asset_paths.asset_for(source, nil).blank? ? "" : asset_paths.asset_for(source, nil).to_path | |||
There was a problem hiding this comment.
Here asset_paths.asset_for is called twice, but I'll fix it after the merge :)
thanks for the patience ;)
EDIT fixed in bd9bcee
elia
added a commit
that referenced
this pull request
Jun 19, 2012
Error fixed when image is missing
dfranciosi
pushed a commit
to dfranciosi/dimensions-rails
that referenced
this pull request
May 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2