Clicking a PDF annotation link now causes an immediate jump to the annotation in markdown-source-view #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notation in markdown-source-view
HardwayLinka
commented
Nov 11, 2022
|
|
||
| public pdfAnnotatorFileModes: { [file: string]: string } = {}; | ||
| private _loaded = false; | ||
| private eventRefs: EventRef[] = []; |
There was a problem hiding this comment.
Use an array to store the events of Obsidian, which is convenient for closing events when closing the software
HardwayLinka
commented
Nov 11, 2022
| @@ -356,25 +389,188 @@ export default class AnnotatorPlugin extends Plugin implements IHasAnnotatorSett | |||
| private addMarkdownPostProcessor() { | |||
| const markdownPostProcessor = async (el: HTMLElement, ctx: MarkdownPostProcessorContext) => { | |||
| for (const link of el.getElementsByClassName('internal-link') as HTMLCollectionOf<HTMLAnchorElement>) { | |||
| const parsedLink = parseLinktext(link.href); | |||
There was a problem hiding this comment.
The form of link.href does not work on Windows, and link.getAttribute("href") works.
HardwayLinka
commented
Nov 11, 2022
| } | ||
| } | ||
|
|
||
| linkOnFocus(element: Element) { |
There was a problem hiding this comment.
when the cursor is focused on the link
HardwayLinka
commented
Nov 11, 2022
| this.tmpLinkInfos.push({linkText: linkText, count: count}); | ||
| } | ||
|
|
||
| linkOnBlur(node: Element, rawLinkText: string, filePath: string, className: string) { |
There was a problem hiding this comment.
When the link loses the cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aladmit , I have added a new feature to the project which is to jump directly to the PDF by clicking on the PDF annotation link in markdown-source-view. And fixed #251.
Click:
Click while holding
ctrl:PS. Ignore the modifications other than
src/main.tsx, because I don't know why so many files were added, maybe because I developed it with windows11?Implementation
Add a file-open listener in Obsidian, add a click event to the PDF annotation link and let MutationObserver observe the PDF annotation link in that listener
Test Objects
A PDF annotation link in one line
A PDF annotation link with multi-line aliases in one line
A PDF annotation link with multi-line aliases and two normal PDF annotation links in one line
A PDF annotation link with multi-line aliases and a normal link in one line
PDF annotation link in list
PDF annotation links in other formats
