Enhancement: Clicking a PDF annotation link now causes an immediate jump to the annotation in markdown-source-view

[HardwayLinka]

Hey, @aladmit, @jonasmerlin, @elias-sundqvist and @rdimaio
Deleted resources/cdn.hypothes.is/hypothesis/build on the basis of #257

ps. Use main.js and manifest.json in 0.2.7patched to test without building the project

[elias-sundqvist]

It looks like clicking links in the markdown source view of the annotation note still does not work. Is this supposed to be covered by the PR?

Some other notes:

• Code looks pretty good, but it could be nice if you moved some of the logic to a separate file so that main.tsx is less cluttered.
• What was the reason for removing this.registerEvent and handling the events manually? I believe the purpose of this.registerEvent is that the events will be removed when the plugin is unloaded.
• I would have preferred if the solution did not use mutation observers, but it is not a deal breaker.

[HardwayLinka]

Hey @elias-sundqvist, thank you for your reply. This PR doesn't cover clicking links in the markdown source view of the annotation note.

1.Code looks pretty good, but it could be nice if you moved some of the logic to a separate file so that main.tsx is less cluttered.

I moved some of the logic from src/main.tsx to src/sourceViewObserver.tsx

2.What was the reason for removing this.registerEvent and handling the events manually? I believe the purpose of this.registerEvent is that the events will be removed when the plugin is unloaded.

bingo

3.I would have preferred if the solution did not use mutation observers, but it is not a deal breaker.

I can't think of a solution other than useing mutation observers

test file here

[elias-sundqvist]

To clarify on 2. I think this is already done automatically by this.registerEvent, so I don't think that part of the PR is needed?

[HardwayLinka]

Hey @elias-sundqvist, I deleted handling the events manually

[aladmit]

It looks like @HardwayLinka resolved all concerns, so I'm going to merge it and release as 0.2.9 🚀

[aladmit]

Fun fact. Plugin didn't start on iOS(#284) because of this line🤡

Turned out it because Safari doesn't support ?<= and throws syntax error. I didn't find other way to exclude [[ with regex and added removing it with hrefLink.substring(2).