Fix #85 with non-empty redhat security source and empty-list checks. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty-list checks. The Red Hat security updates are deprecated, and the old source location now contains just an empty directory tree. This caused Dagda to attempt to push empty lists into the MongoDB, which generated eliasgranderubio#85. This fix both adds protections on the MongoDB write by not writing empty lists, and by changing the download URL to one that works. Note that this is a temporary fix, because the Red Hat update indicates that this is still a deprecated source. The v2 should be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
The Red Hat security updates are deprecated, and the old source location now contains just an empty directory tree. This caused Dagda to attempt to push empty lists into the MongoDB, which generated #85. This fix both adds protections on the MongoDB write by not writing empty lists, and by changing the download URL to one that works. Note that this is a temporary fix, because the Red Hat update indicates that this is still a deprecated source. The v2 should be used instead.
Related PRs
Unknown.
TO-DOs
I don't believe there to be any documentation changes necessary.
Deploy Notes
No changes are necessary for deployments. Currently, it is unknown whether this upgrade will have major changes to existing databases, due to the change in the URL for pulling down the alternate list of security issues.
Steps to Test or Reproduce
Testing:
Impacted Areas in Application
This affects the Red Hat security issues URL, which currently is an empty tar file.