Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Respect cache lifetime when getting cached solutions #127

Merged
merged 1 commit into from
May 28, 2023

Conversation

eliashaeussler
Copy link
Owner

When calling SolutionsCache::get(), the configured cache lifetime is now properly respected. If caching is disabled by setting cache lifetime to 0 seconds, SolutionsCache::get() will always return null. For this, a new method Configuration::isCacheEnabled() was added.

@eliashaeussler eliashaeussler added the bug Something isn't working label May 28, 2023
@eliashaeussler eliashaeussler self-assigned this May 28, 2023
@codeclimate
Copy link

codeclimate bot commented May 28, 2023

Code Climate has analyzed commit b08d916 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.0% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (c2d6720) 87.01% compared to head (b08d916) 87.06%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #127      +/-   ##
============================================
+ Coverage     87.01%   87.06%   +0.05%     
- Complexity      274      277       +3     
============================================
  Files            44       44              
  Lines           978      982       +4     
============================================
+ Hits            851      855       +4     
  Misses          127      127              
Impacted Files Coverage Δ
Classes/Cache/SolutionsCache.php 100.00% <100.00%> (ø)
Classes/Configuration/Configuration.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eliashaeussler eliashaeussler merged commit 399dffa into main May 28, 2023
@eliashaeussler eliashaeussler deleted the fix/respect-cache-lifetime branch May 28, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant