[!!!][FEATURE] Use dependency injection where possible #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
added
enhancement
|
Code Climate has analyzed commit 0384bb6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 84.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.5% (1.4% change). View more on Code Climate. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
============================================
+ Coverage 86.17% 87.58% +1.40%
- Complexity 244 255 +11
============================================
Files 39 41 +2
Lines 890 910 +20
============================================
+ Hits 767 797 +30
+ Misses 123 113 -10
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
eliashaeussler
force-pushed
the
feature/di
branch
4 times, most recently
from
3575a10
to
0a606f9
Compare
eliashaeussler
force-pushed
the
feature/di
branch
from
0a606f9
to
0384bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites a bunch of classes to allow constructor injection using the service container. Since several classes are also used on a very low level, some of them are still instantiated by without the service container. In addition, solution providers and prompts are now forced to implement a
create()factory method.