Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ply: remove unused base64 import #540

Closed
wants to merge 1 commit into from
Closed

ply: remove unused base64 import #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pycparser/ply/yacc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
import sys
import os.path
import inspect
import base64
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is in a dependency, so I'm not going to accept it, sorry.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eliben Thanks for the review. I understand not touching dependencies.

I noticed this import has been removed in a version of the ply source code I just quickly glanced at. (Version 3.11) so maybe it makes more sense to update the bundled ply source.

Would it be much work/risk to update the ply source in pycparser? I could submit a PR if you want, but I’m not familiar enough with pycparser to do extensive tests on the code base.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not objecting to upgrading to ply 3.11, but this first requires a separate issue to be created. The commit history should be reviewed to see if any changes to ply were applied after the previous version upgrade

import warnings

__version__ = '3.10'
Expand Down