Feature: gRPC Web #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
force-pushed
the
feat/grpc-web
branch
4 times, most recently
from
454c8e2
to
9fe0ff9
Compare
Codecov Report
@@ Coverage Diff @@
## v3 #9 +/- ##
=====================================
Coverage ? 66.04%
Complexity ? 160
=====================================
Files ? 27
Lines ? 1125
Branches ? 95
=====================================
Hits ? 743
Misses ? 359
Partials ? 23 Continue to review full report at Codecov.
|
sgammon
force-pushed
the
feat/grpc-web
branch
10 times, most recently
from
798e7fa
to
178a88a
Compare
sgammon
added
module:rpc
sgammon
force-pushed
the
feat/grpc-web
branch
2 times, most recently
from
3e473e0
to
96a59ce
Compare
This changeset introduces support for gRPC Web via a pure Kotlin server-side implementation for the JVM. At runtime, the gRPC server is observed by a bean creation listener, which then informs a new RPC runtime layer of services which should be eligible for dispatch via gRPC Web. A controller registered for the user is then responsible for decoding requests, resolving/dispatching them, and encoding the resulting response back to the client, all in a manner compliant with the [gRPC Web Protocol][1]. Changes enclosed: - Add RPC runtime layer, bean observer - Add initial structure to decode and encode gRPC Web traffic - Add testsuite for decoding and processing gRPC Web traffic - Ability to encode/decode trailer-equipped responses - Error cases in testsuite [1]: https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset introduces support for gRPC Web via a pure Kotlin server-side implementation for the JVM.
At runtime, the gRPC server is observed by a bean creation listener, which then informs a new RPC runtime layer of services which should be eligible for dispatch via gRPC Web.
A controller registered for the user is then responsible for decoding requests, resolving/dispatching them, and encoding the resulting response back to the client, all in a manner compliant with the gRPC Web Protocol.
Changelog
Register centralnote: this was a bad ideaAppExecutorfor use with user's gRPC serverGoldensnahModule-level docsnote: future PRJS-side library buildnote: future PRConsideration for web-side testsnote: future PRFull client testsnote: future PR