Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: abort_on_prompts #18

Merged
merged 8 commits into from
Dec 16, 2019
Merged

feature: abort_on_prompts #18

merged 8 commits into from
Dec 16, 2019

Conversation

lsh-0
Copy link
Contributor

@lsh-0 lsh-0 commented Dec 10, 2019


  • updated TODO with explanation of 'abort_on_prompts'

@lsh-0
Copy link
Contributor Author

lsh-0 commented Dec 10, 2019

I've taken a look and I suspect none of our usages of this setting are appropriate.

update: oh no! what is this abomination?? Because it looks like it's reading output and looking for the presence of user-defined prompts ...

threadbare/__init__.py Outdated Show resolved Hide resolved
threadbare/execute.py Outdated Show resolved Hide resolved
@lsh-0 lsh-0 marked this pull request as ready for review December 16, 2019 06:33
@lsh-0 lsh-0 merged commit 8c4fd12 into develop Dec 16, 2019
@lsh-0 lsh-0 deleted the abort-on-prompts branch December 16, 2019 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant