Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Spike - not for merging #27

Open
wants to merge 98 commits into
base: master
Choose a base branch
from
Open

List Spike - not for merging #27

wants to merge 98 commits into from

Commits on Oct 4, 2015

  1. WIP: List API

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5ce821a View commit details
    Browse the repository at this point in the history

  2. Authorizer adds X-Api-Key to API request headers

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    d9c2d2a View commit details
    Browse the repository at this point in the history

  3. Document next steps for list page

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5d7a686 View commit details
    Browse the repository at this point in the history

  4. Style lists page draft

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    eb2a60e View commit details
    Browse the repository at this point in the history

  5. List styling WIP

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    43c7cae View commit details
    Browse the repository at this point in the history

  6. Tweak colors

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    c9459da View commit details
    Browse the repository at this point in the history

  7. Reminder to migrate Polish notes

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    aa6ac91 View commit details
    Browse the repository at this point in the history

  8. Style lists, remove tables

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    57fec10 View commit details
    Browse the repository at this point in the history

  9. Remove footer from Your Lists

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b981ff7 View commit details
    Browse the repository at this point in the history

  10. New Lists link at top of list

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    7613ace View commit details
    Browse the repository at this point in the history

  11. Remove stale WIP from WIP.md

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    732bc48 View commit details
    Browse the repository at this point in the history

  12. Simplify remaining CRUD tasks for Your lists

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    3189d14 View commit details
    Browse the repository at this point in the history

  13. Style link to new list

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    f57af67 View commit details
    Browse the repository at this point in the history

  14. Use Ember's link-to

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    0f41ec8 View commit details
    Browse the repository at this point in the history

  15. Add list.new route

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    cd2d48a View commit details
    Browse the repository at this point in the history

  16. Move nav to appear only on home page

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    077c379 View commit details
    Browse the repository at this point in the history

  17. Move nav to appear only on home page

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    d605515 View commit details
    Browse the repository at this point in the history

  18. Introduce header style and nav link

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    1179904 View commit details
    Browse the repository at this point in the history

  19. New list-form component

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    128e3e0 View commit details
    Browse the repository at this point in the history

  20. Tweak header colors

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b641979 View commit details
    Browse the repository at this point in the history

  21. Notes on duplicate list creation with null id issue

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    29814cb View commit details
    Browse the repository at this point in the history

  22. Make ListsController#create API Ember-Data compliant

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5e5d8e6 View commit details
    Browse the repository at this point in the history

  23. Use isDirty

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    0f5a363 View commit details
    Browse the repository at this point in the history

  24. Notes on what to do next

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    9defa7a View commit details
    Browse the repository at this point in the history

  25. JsonHelper.parse(str) method added

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    fc296ea View commit details
    Browse the repository at this point in the history

  26. Installed binstubs for pry-rescue

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    4ec38fe View commit details
    Browse the repository at this point in the history

  27. Install pry-rescue

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5eae622 View commit details
    Browse the repository at this point in the history

  28. Implement and test ListSerializer

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    c475bef View commit details
    Browse the repository at this point in the history

  29. Fix test for Api::ListsController#create

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    24c2bd2 View commit details
    Browse the repository at this point in the history

  30. Juggling code in list-form component

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    cbae317 View commit details
    Browse the repository at this point in the history

  31. Disable save button when saving

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    46359cb View commit details
    Browse the repository at this point in the history

  32. Add ellipsis to 'Saving...' button text

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    fa24ad3 View commit details
    Browse the repository at this point in the history

  33. Beginning New List Feature Spec

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b88bb42 View commit details
    Browse the repository at this point in the history

  34. Shared footer styles

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    9aa599b View commit details
    Browse the repository at this point in the history

  35. Put all login helper methods in login_helper

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ad7cdb8 View commit details
    Browse the repository at this point in the history

  36. Sign out link in lists footer

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    c106a02 View commit details
    Browse the repository at this point in the history

  37. Introduce visit_login_page_and_login helper method

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ce287a8 View commit details
    Browse the repository at this point in the history

  38. De-emphasize Sign Out link

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    e6c2cb5 View commit details
    Browse the repository at this point in the history

  39. Older Ember uses isDirty not hasDirtyAttributes

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    57a054a View commit details
    Browse the repository at this point in the history

  40. Add clear_notification option to login helper

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b5b86cf View commit details
    Browse the repository at this point in the history

  41. Offline-first/last notes

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    7d89b33 View commit details
    Browse the repository at this point in the history

  42. Add migration to make list title non-null

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5ed9c1f View commit details
    Browse the repository at this point in the history

  43. Reminder to run rake db:migrate

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a4a19fa View commit details
    Browse the repository at this point in the history

  44. Add validation for required list title

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ec562e5 View commit details
    Browse the repository at this point in the history

  45. Remove required from input field

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    18a85f1 View commit details
    Browse the repository at this point in the history

  46. Progress with list features

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a96b03d View commit details
    Browse the repository at this point in the history

  47. Handle invalid list creation via API

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    6fb9f26 View commit details
    Browse the repository at this point in the history

  48. Show validation error if user tries to save blank list title

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b6c70fe View commit details
    Browse the repository at this point in the history

  49. Add missing semi-colon

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    f8469ba View commit details
    Browse the repository at this point in the history

  50. Test cancelled lists with titles aren't shown in index

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    6e18e32 View commit details
    Browse the repository at this point in the history

  51. Remove stale feature specs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    201d40b View commit details
    Browse the repository at this point in the history

  52. Add list page matchers module

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ad90fc3 View commit details
    Browse the repository at this point in the history

  53. Begin work on edit & delete list feature specs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b55f5e9 View commit details
    Browse the repository at this point in the history

  54. Edit mode link in 'Your Lists' page

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    dcdd860 View commit details
    Browse the repository at this point in the history

  55. List edit mode specs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    7097523 View commit details
    Browse the repository at this point in the history

  56. Rename feature spec to list_index from view_lists

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a81fc59 View commit details
    Browse the repository at this point in the history

  57. Generate controller with 'bin/ember generate controller list/index --… 

    …pod'
    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a5f6731 View commit details
    Browse the repository at this point in the history

  58. Introduce editsLocked queryParam

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a5611a6 View commit details
    Browse the repository at this point in the history

  59. Note on ember generate controller

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    191936c View commit details
    Browse the repository at this point in the history

  60. Edit List Route

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    1ff975f View commit details
    Browse the repository at this point in the history

  61. WIP: Handle list edits

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    fc904cd View commit details
    Browse the repository at this point in the history

  62. Work towards edit and new route handling their own

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    628acb6 View commit details
    Browse the repository at this point in the history

  63. Move edit unlock test to more appropriate feature spec

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    02b8e4e View commit details
    Browse the repository at this point in the history

  64. Remove unused comments

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    2b07797 View commit details
    Browse the repository at this point in the history

  65. Fix lint errors

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    61d4836 View commit details
    Browse the repository at this point in the history

  66. Fix lint errors

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    2dd0433 View commit details
    Browse the repository at this point in the history

  67. WIP: Moving action work into routes

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b58c3fa View commit details
    Browse the repository at this point in the history

  68. Use transitionTo directly

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    4c86350 View commit details
    Browse the repository at this point in the history

  69. Refactor out duplication

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    44a1846 View commit details
    Browse the repository at this point in the history

  70. Better test coverage

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    4731ee5 View commit details
    Browse the repository at this point in the history

  71. Update list request spec (failing)

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a6278cc View commit details
    Browse the repository at this point in the history

  72. Update todos

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    e1c72eb View commit details
    Browse the repository at this point in the history

  73. Logout page for testing use greens instead of reds

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    50c6afc View commit details
    Browse the repository at this point in the history

  74. Restrict lists API routes

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    3c9475f View commit details
    Browse the repository at this point in the history

  75. Replace where.first with find_by in authenticate

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    a0b6b09 View commit details
    Browse the repository at this point in the history

  76. Favor current_user over @user

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    bbd431e View commit details
    Browse the repository at this point in the history

  77. Consolidate error handling into render_errors

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    0bf84d1 View commit details
    Browse the repository at this point in the history

  78. Test for blank list title when no list given

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    40beb1f View commit details
    Browse the repository at this point in the history

  79. Temporary stiches for update list spec for non-API controller

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    5cbd68d View commit details
    Browse the repository at this point in the history

  80. Delete list working

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    2ad7da0 View commit details
    Browse the repository at this point in the history

  81. Delete list spec passing

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    308d69e View commit details
    Browse the repository at this point in the history

  82. Show Deleting... on button if list is being deleted

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    49fe4b0 View commit details
    Browse the repository at this point in the history

  83. Common transitionToListIndex() function

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b4e5f4b View commit details
    Browse the repository at this point in the history

  84. Remove unneeded local variables

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ab5052a View commit details
    Browse the repository at this point in the history

  85. Convenience notify(msg) function

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    160008e View commit details
    Browse the repository at this point in the history

  86. Reminders of next steps

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    b54101a View commit details
    Browse the repository at this point in the history

  87. WIP GET /api/v1/lists/:id to show list via JSON

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    d4e0840 View commit details
    Browse the repository at this point in the history

  88. Assert API lists/show unauthorized response when auth token missing

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    3538b68 View commit details
    Browse the repository at this point in the history

  89. Test show list API responds with 404 Not Found for list belonging to … 

    …another user
    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    187f900 View commit details
    Browse the repository at this point in the history

  90. GET /api/v1/lists/:id responds with 404 Not Found for non-existent list

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    0fb4229 View commit details
    Browse the repository at this point in the history

  91. Refresh module for feature specs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    373a6b0 View commit details
    Browse the repository at this point in the history

  92. Use refresh module

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    41b9d8c View commit details
    Browse the repository at this point in the history

  93. Test that edit list page is refreshable

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    262b370 View commit details
    Browse the repository at this point in the history

  94. Update TODOs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    adbbd32 View commit details
    Browse the repository at this point in the history

  95. Style delete button in red

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    d3c5c1f View commit details
    Browse the repository at this point in the history

  96. Style Edit List links

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    52129b7 View commit details
    Browse the repository at this point in the history

  97. Update TODOs

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    ef87397 View commit details
    Browse the repository at this point in the history

  98. Get edit/delete list buttons displaying reliably

    @eliotsykes
    eliotsykes committed Oct 4, 2015
    Copy the full SHA
    aa8781c View commit details
    Browse the repository at this point in the history