List Spike - not for merging

GUIDE.md

@@ -4147,3 +4147,174 @@ How are all the 2 feature specs we've written doing? Run them both, they should
 ```bash
 bin/rspec spec/features/user_*
 ```
+
+
+## List UI
+
+Spike in progress.
+
+Spike should enable:
+
+- view lists
+- create list
+- delete list
+- edit list
+
+See `~/dev/app-store-rails/asr-todo/client` for approach in that app. In-line editing, see `~/dev/app-store-rails/asr-todo/client/app/templates/components/todo-widget.hbs`
+
+Run:
+```bash
+bin/ember generate model list title:string --pod
+```
+
+outputs:
+```
+installing
+  create app/pods/list/model.js
+installing
+  create tests/unit/pods/list/model-test.js
+```
+
+TODO: Add spec for list page first before generating model
+
+Generate application authorizer. The authorizer is responsible for including the API token in every request to the backend.
+
+```bash
+bin/ember generate authorizer application
+```
+outputs and creates file:
+```
+installing
+  create app/authorizers/application.js
+```
+
+Configure the authorizer to use in `ENV['simple-auth']` in `client/config/environment.js`:
+
+```diff
+--- a/client/config/environment.js
++++ b/client/config/environment.js
+@@ -23,7 +23,8 @@ module.exports = function(environment) {
+
+   ENV['simple-auth'] = {
+     authenticationRoute: 'session.new',
+-    routeAfterAuthentication: 'list'
++    routeAfterAuthentication: 'list',
++    authorizer: 'authorizer:application'
+   };
+
+   if (environment === 'development') {
+```
+
+Save `client/app/authorizers/application.js` with contents:
+
+```diff
+--- /dev/null
++++ b/client/app/authorizers/application.js
+@@ -0,0 +1,12 @@
++import Base from 'simple-auth/authorizers/base';
++
++export default Base.extend({
++  authorize(jqXHR, requestOptions) {
++    let isAuthenticated = this.get('session.isAuthenticated');
++    let token = this.get('session.secure.token');
++
++    if (isAuthenticated && !Ember.isEmpty(token)) {
++      jqXHR.setRequestHeader('X-Api-Key', token);
++    }
++  }
++});
+```
+
+Modify `client/app/pods/list/index/route.js`:
+
+```js
+import Ember from 'ember';
+
+export default Ember.Route.extend({
+  model() {
+    return this.store.findAll('list');
+  }
+});
+```
+
+Modify `client/app/pods/list/index/template.hbs`:
+
+```
+TODO
+```
+
+TODO: Instructions on updating stylesheets to latest and add new ones.
+
+Run Ember's generate command to generate a route for creating new lists:
+
+```bash
+# Inside your-rails-app/ directory:
+bin/ember generate route list/new --pod
+```
+
+This will generate the following output and files inside the list pod:
+
+```
+installing
+  create app/pods/list/new/route.js
+  create app/pods/list/new/template.hbs
+installing
+  create tests/unit/pods/list/new/route-test.js
+```
+
+The generate will modify `client/app/router.js` for you, by nesting the `list.new` route within the existing `list` route:
+
+```diff
+--- a/client/app/router.js
++++ b/client/app/router.js
+@@ -12,7 +12,9 @@ Router.map(function() {
+   this.route('user.new', { path: '/register' });
+   this.route('confirmation-pending');
+   this.route('session.new', { path: '/login' });
+-  this.route('list', function() {});
++  this.route('list', function() {
++    this.route('new');
++  });
+ });
+
+ export default Router;
+```
+
+The name of this component will be `list-form`. Generate it with this command:
+
+```bash
+bin/ember generate component list-form --pod
+```
+
+Generates:
+
+```
+installing
+  create app/pods/components/list-form/component.js
+  create app/pods/components/list-form/template.hbs
+installing
+  create tests/unit/pods/components/list-form/component-test.js
+```
+
+
+`ListsController#create` needed tweaks:
+
+- `status: :created`
+- Root node of `list` in generated JSON (requirement of Ember Data)
+
+
+Explain `Model#isSaving` and other related `isMethods` and what dirty attributes are.
+
+TODO: Include instructions to run `rake db:migrate` since changing null constraint of lists title column.
+
+```bash
+# Generate controller needed for queryParams.editsLocked:
+bin/ember generate controller list/index --pod
+```
+
+```bash
+# Generate route with path option for editing list:
+bin/ember generate route list/edit --path=:list_id/edit --pod
+```
+
+TODO: Merge POLISH.md notes from branch to master

Gemfile

@@ -13,7 +13,6 @@ group :development do
 end
 
 group :test do
-  gem 'rspec-rails', '~> 3.1.0'
   gem 'database_cleaner'
   gem 'factory_girl_rails'
   gem 'capybara'
@@ -23,7 +22,10 @@ group :test do
 end
 
 group :development, :test do
+  gem 'rspec-rails', '~> 3.1.0'
+  gem 'rspec'
   gem 'pry-rails'
+  gem 'pry-rescue'
   gem 'spring-commands-rspec'
 end
 

Gemfile.lock

@@ -102,6 +102,7 @@ GEM
       activesupport (>= 4.1.0)
     hike (1.2.3)
     i18n (0.7.0)
+    interception (0.5)
     jbuilder (2.2.12)
       activesupport (>= 3.0.0, < 5)
       multi_json (~> 1.2)
@@ -132,6 +133,9 @@ GEM
       slop (~> 3.4)
     pry-rails (0.3.4)
       pry (>= 0.9.10)
+    pry-rescue (1.4.2)
+      interception (>= 0.5)
+      pry
     pundit (0.3.0)
       activesupport (>= 3.0.0)
     rack (1.6.0)
@@ -173,6 +177,10 @@ GEM
       railties (>= 4.2.0, < 5)
     restclient (0.10.1)
       paint (~> 0.8)
+    rspec (3.1.0)
+      rspec-core (~> 3.1.0)
+      rspec-expectations (~> 3.1.0)
+      rspec-mocks (~> 3.1.0)
     rspec-core (3.1.7)
       rspec-support (~> 3.1.0)
     rspec-expectations (3.1.2)
@@ -266,10 +274,12 @@ DEPENDENCIES
   jquery-rails
   pg
   pry-rails
+  pry-rescue
   pundit
   rails (= 4.2.0)
   rails_12factor
   restclient
+  rspec
   rspec-rails (~> 3.1.0)
   sass-rails (~> 4.0.3)
   sdoc (~> 0.4.0)

app/controllers/api/api_controller.rb

@@ -1,5 +1,5 @@
 class Api::ApiController < ActionController::Base
-  
+
   before_action :authenticate
 
   private
@@ -10,11 +10,11 @@ def current_user
 
   def authenticate
     api_key = request.headers['X-Api-Key']
-    @user = User.where(api_key: api_key).first if api_key
-   
+    @user = User.find_by(api_key: api_key) if api_key
+
     unless @user
       head status: :unauthorized
       return false
     end
   end
-end
+end

app/controllers/api/v1/lists_controller.rb

@@ -2,31 +2,43 @@ class Api::V1::ListsController < Api::ApiController
   respond_to :json
 
   def index
-    render json: @user.lists
+    render json: current_user.lists
   end
 
-  def new
-    @list = List.new
+  def show
+    render json: current_user.lists.find(params[:id])
   end
 
   def create
-    @list = @user.lists.new(list_params)
-    if @list.save
-      render json: @list
+    list = current_user.lists.new(list_params)
+    if list.save
+      render json: list, status: :created
+    else
+      render_errors list
     end
   end
 
   def update
-    respond_with current_user.lists.find(params[:id]).update_attributes(list_params)
+    list = current_user.lists.find(params[:id])
+    if list.update(list_params)
+      head :no_content
+    else
+      render_errors list
+    end
   end
 
   def destroy
     respond_with current_user.lists.destroy(params[:id])
   end
 
   private
+
   def list_params
     params.require(:list).permit(:title)
   end
 
+  def render_errors(list)
+    render json: {errors: list.errors.full_messages}, status: :unprocessable_entity
+  end
+
 end

app/models/list.rb

@@ -1,4 +1,6 @@
 class List < ActiveRecord::Base
   belongs_to :user
   has_many :items
+
+  validates :title, presence: true
 end

app/serializers/list_serializer.rb

@@ -0,0 +1,3 @@
+class ListSerializer < ActiveModel::Serializer
+  attributes :id, :title
+end

bin/kill-pry-rescue

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+#
+# This file was generated by Bundler.
+#
+# The application 'kill-pry-rescue' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('pry-rescue', 'kill-pry-rescue')

bin/rescue

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+#
+# This file was generated by Bundler.
+#
+# The application 'rescue' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('pry-rescue', 'rescue')

client/app/authorizers/application.js

@@ -0,0 +1,13 @@
+import Ember from 'ember';
+import Base from 'simple-auth/authorizers/base';
+
+export default Base.extend({
+  authorize(jqXHR/*, requestOptions*/) {
+    let isAuthenticated = this.get('session.isAuthenticated');
+    let token = this.get('session.secure.token');
+
+    if (isAuthenticated && !Ember.isEmpty(token)) {
+      jqXHR.setRequestHeader('X-Api-Key', token);
+    }
+  }
+});