-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side effects playing the game at 60 FPS #28
Comments
Honestly, this is going to require a lot of patching and research and I'm not sure I can fix everything either. If I were to attempt this I would need help.
I've fixed these during my own private testing.
I know for a fact I can't fix this. I spent all day trying and found nothing. I thought maybe this was the only problem remaining, but with the other things you've listed I'm afraid I'm going to have trouble fixing those as well. There's a framerate variable the game uses to determine the speed of many, many things, but apparently the ritual monster isn't one of them. |
Oh, for sure. I didn't mean to overwhelm you with this but wrote this all down for posterity for you or anyone else curious to know how 60 FPS affects things. TBH work on this ought to be lower on the list anyways. |
Do you know of a way to remove the shell casing sound effect? For me, it's the only offender when playing that 60 fps. |
Yes, if you delete the file all other sounds are moved over to fill the space. So sddata350 then becomes sddata349 in the game, sddata351 becomes sddata350, etc. You simply need to create a silent .WAV file and save it out as sddata349.wav. Be sure you save it as a mono (not stereo) wave file. The length of the silent audio file shouldn't matter here. Then, repeat the process of re-packaging the sound files to a new sddata.bin and you're good to go. |
I see. I thought deleting the content in sddata349.wav and saving it as a blank wav file would be enough though. Am I doing something wrong? |
Are you just renaming a blank .txt to .wav or something? That would be the problem why, then. You'll need an actual, legit silent audio .wav file for it to work. You can open a short .wav file in Audacity, select the track , click the "silence" button , and save it out as Edit: Here's a roughly 1-second silent .wav file for you to use: sddata349.zip |
Oh, I think I understand now. You deleted the entire track of sddata349.wav and saved it out as-is? If so, there's no track for the game to play then, so it won't work. There needs to be a track for sddata349. So make it a second or two of silence. When you open the track in Audacity, you need to see some sort of track, if that makes sense. Edit: Here's a roughly 1-second silent .wav file for you to use: sddata349.zip |
I see. Thank you for specifying....and for the instruction on how to create a silent wav file. ^_^ EDIT: Works like a charm! thanks for telling me what to do. |
I have a GTX 1060 and expierience framedrops when playing with 60fps, also in SH3. I don't think it's really our hardware not able to keep up with a 15 years old PC game. :) |
True. :) I can't speak for SH3, but I know forcing SH2 PC to run on a single core doesn't take advantage of multi-core processing to help with performance. But we must run the game on a single core to alleviate the severe sound loop bug. |
I'm curious to see the fixes Aero has planned for us. 60 FPS is the only way to play :) |
There's potential for some more really nice fixes down the line thanks to Aero, Elisha, Bigmanjapan, and others. :) |
Actually I think I have to revoke what I said earlier. Last time I tried playing with 60fps was one or two years ago, now (perhaps due to the opengl-wrapper?) it actually runs pretty smooth (tested for about 10min). CPU-Load on Core 0 is always 100%, it doesn't matter if 30 or 60 FPS |
I've been getting fairly consistent FPS myself. The streets are the only areas where the the fps....doesn't drop but hitch for a fraction of a second and it doesn't happen often. |
Can anyone link the edited sound file (replacing the bullet casing sound with silence) on here for easy access? I’d love to be able to play either 30 or 60 fps with as little trouble as possible. |
OregonPacifist, Polymega posted a link to the edited sddata file a few comments up. Just remember to back up your original sddata file before using it. |
@filipinowhiteboy thanks for the reply. I was looking for an already edited version of sddata.bin. The only file I saw that was posted is a silent sddata349.wav file. |
@OregonPacifist Oh! I see. Give me a second, I'll link mine. EDIT: Here you go Now remember, You want to backup your old sddata file in case you change your mind and want to keep the sfx and play at 30fps. Also, the sddata file I sent you, must be placed in the sh2e/sound folder. This file will NOT work with the main sound from the data folder. |
@filipinowhiteboy Thanks for the link. I haven't used any audio editing software before and don't have enough time to learn it lol. I will be sure to save the two different versions of the file separately in case I want to play 30 or 60 FPS. You've just made my day! |
@OregonPacifist You're welcome. Let me know if there's a problem. |
Are all these issues still present in the latest release when playing at 60 fps? |
@DonelBueno Yes, it is. I think they might have updated the enhanced sound file recently. I might have to make a new version of the sdata file if they did. |
Besides any issues checked off, they are still present in the game, yes. |
I would like to have some sort of a starting point to improve and try to fix the various issues that is caused by high framerates, @AeroWidescreen would you be able give me some help with that? Also in need of save files to diagnose the various issues. |
@Murugo The issue: When played at 60 FPS, if you skip the PC credits FMV it'll also skip over the Game Results stats screen and take you directly to the "Save clear data" screen. If you let the PC credits video play out, it'll correctly take you to the Game Results screen. Pro-tip: If needed for testing, make a backup of your credits.bik video, then copy toilet.bik and rename it to credits.bik for testing. |
I think I understand what's happening: After the PC credits FMV three other screens then happen: Game Results screen > "Save clear data" > Save screen. If you keep the Esc/Pause button held down after skipping the PC credits FMV it'll also skip over the next two screens, taking you to the last screen (Save Screen). What's happening is when you press Esc/Pause to skip the PC credits FMV, if the button is held down for even a fraction too long it'll skip over the Game Results screen. Hold it down a bit longer than that? It'll skip the next two screens, bringing you to the final Save Screen. I think because fade times are a smidge quicker at 60 FPS, it reduces the "tolerance time" in pressing the Esc/Pause button on the PC credits FMV. Here is a save folder with all the endings. The DOG ending is the quickest way to constantly test this: |
@Polymega do you think it could be a solution to this to hide the SKIP input from the game when holding the key? With the InputTweaks feature it could be done easily edit: |
Certainly worth a shot! I'm not sure how to word/describe this right, but can you whip something up that does the following? If a user presses KEY_SKIP/KEY_CANCEL during an in-game FMV ( |
My only concern with that is how often the game picks up key inputs. It looks like there are two threads picking up key inputs, so inputs are checked twice a frame. I recommend keeping the input for at least one frame and then dropping the other inputs if the key press continues longer than a frame. Hopefully, the game is able to pick up key presses every frame and does not skip picking up inputs for a frame if the system is too busy. Would be nice if we could control how many frames the input can remain before we skip the input. Just a thought... |
Right Elisha. |
Unfortunately it's still skipping over the Game Results screen. Make a backup of your Open the "ReadMe" in that folder to know which save is for which ending. Launch the game and it's easiest to test with the DOG ending. Trigger the ending, get to the PC credits FMV and press/hold Esc/Pause on the FMV. You'll see it jumps over the Game Results screen and takes you straight to the Save screen. |
Ok my bad, I was testing with that save but tested only the FMV for some reason... |
Nice one, mercury! Quick tests and things seem to be great. So I think the next question is: Should this belong only in the 60 FPS feature, or should it be included into a different feature or made into its own thing? Because technically this issue can happen at any framerate. Once we get that decided, if you can please send Elisha a PR he'll then get everything together into one test build and I'll get to testing everything. Thanks for chiming in and helping out with this, friend! |
Anytime, the InputTweaks framework has become quite useful, I'm happy about that. Don't know if it's worth to make a setting just for this. Should we maybe transform MemoScreenFix in some more generic, QOL input changes setting? |
Sounds great to me!
Ahh... I don't think so. Unless anyone objects, I'd say not to worry about breaking up or renaming things. |
Right on then, I'll make a pr in a bit then! |
So the skipping result screen. wasn't because of my controller but a bug interesting. |
@Polymega I think I might have found another side effect of playing the game at 60FPS that went unnoticed: when you do the "swing sideways" attack with the steel pipe and hit an enemy, James' "recoil" animation plays at a higher speed, allowing you to attack in EXTREMELY quick succession. It's really, really funny to see, I highly recommend you try it out. You can even make the animation of the enemy you're attacking glitch out with how fast James batters them (which is what clued me that something may have been wrong in the first place). Edit: actually, I was incorrect about the animation thing, it's the nurse's animation when hit with a melee weapon on their left side that is glitchy, 60FPS just makes it more apparent! It can also happen when you hit them with the wooden plank. ETA 2: also there's a problem with padlocks in puzzle screens when playing in 60FPS, but I believe you might already know that since it's very easy to notice (mouse clicks get registered twice, thus you rotate two numbers in the number wheels when clicking). |
Huh, would you look at that. Left is 30 FPS, right is 60 FPS. 2023-09-09.14-48-39000-1.mp4I personally feel this isn't an issue worrying about. I say this for two reasons: 1) Most people don't even know about this attack and 2) even at 30 FPS, it still swings pretty darn fast, so what's a little faster at that point? 😏 I'll ping @Murugo about this so he's aware and leave it in his hands over whether or not it's worth addressing. I personally don't think it's that big of a deal, but Murugo should be the one to decide.
Do you mean how it appears as if their spines are breaking (as their torso "falls back") after being hit like that? If so, I think that's intentional.
Hmm... I don't experience this problem. And from other people I've watched stream the project with the 60 FPS feature, I haven't seen them experience this issue, either. |
No, it's not that. Their head "glitches out" and almost becomes disjointed from their body, it's very easy to notice. I'll try to capture it with OBS to show you. Edit: well I can't get the game to stay at 60 when recording. I'll see if I can do a hack job with my cellphone.
🤔 Well that's weird. I'll also try to capture this to show you. I noticed it happening in the "Louise" box, but I'll see if it also happens in the hotel briefcase as well. |
Gotcha. I was hitting them with a light melee using the plank. You meant with hard melee. I checked against PS2 version and it's an intentional animation: 2023-09-09.15-32-22.mp4 |
😬 Welp I'll be damned, sorry, but you were right, I was indeed referring to the "spine breaking" animation, I just thought of it less as a "spine break" and more as a "head gets sent flying to the stratosphere" animation which is why I thought you were referring to something else. I'm very sorry for the confusion. 2023-09-09-17-03-12.mp4You can see it in this video right at the beginning, her head and back get sent flying back at ludicrous speed, which I thought could've been a glitch. Pay attention specially to the third blow I deal to her. It's even more noticeable when you're battering them at Mach 5 speed with the pipe. In 30FPS I can't remember it being this apparent. (Also I managed to get OBS to record at 60 without the framerate dropping, woohoo! But I had to reduce the game's resolution...) Edit: about that one with the strong hard you posted above, yeah I figured that one was intentionally made like so as a homage to that gurney scene in Jacob's Ladder. In all Team Silent games they have enemies with that sort of crazy twitchy movement going on. |
2023-09-09-23-04-08.mp4Here I'm clicking only once and pausing between clicks, yet the number wheel will quickly jump two numbers sometimes. |
@Polymega Not sure if you saw these messages above? 😬 |
For the double input:
|
Yes, even at the lowest resolution with no other programs open.
Well, unfortunately I can't test this because I still haven't solved this issue... Sorry.
No.
It does. Also I just tested it and it does happen at 30FPS, for some reason I just cannot remember ever facing this issue before. Really, I think this must be something new. And no, it does not happen when using the mouse to skip dialogue or interact, it only happens in the puzzle screens (so far I've had this happen at the Louise box and the keypad to the hospital 3rd floor patient wing, I can make a new issue if you want since this isn't 60FPS-related. Edit: or rather, since this is just such a freak incident that hasn't affected anyone else, we can maybe just forget about it and attribute it to SH2 PC being weird. It's just a very minor inconvenience really. |
From what I can tell, every melee attack is slightly faster in 60 FPS (at least with the wooden plank and steel pipe, possibly others). This is more apparent with the steel pipe since the rebound from the swing animation is very fast. There are a few reasons for this:
Solving this fully would be difficult due to the sheer number of corner cases. This isn't a solution per se, but there is a way to compensate for the time difference by delaying the rebound animation by a number of frames. To test this out: sh2pc-1.0-delay-melee-rebound.zip I'm not too happy with this approach right now because:
PatchComparison.mp4 |
We talked about the pipe swinging thing more behind-the-scenes and have decided, at this time, to not change anything about it. There's no obvious "elegant" way to handle this and we don't feel great about the solutions presented to us for this. The silver lining to this is that very, very few people know about this attack and it can only be used in one Action Mode, so we're not overly worried about leaving it as-is. |
Very interesting breakdown, I hadn't actually noticed all other melee attacks are faster too. Thanks for all the info. |
You can use this save folder to reference some of the framerate issues mentioned below. Go to
<path-to-game>\data\save\
and make a backup of yourFolder 01
folder within here. Then, completely replace yourFolder 01
folder with this new one.Important (noticeably affects audio, visuals, gameplay)
Data 57
,Data 58
,Data 59
,Data 60
to test. There are many water spots throughout the Labyrinth and Alternate Hotel areas.Data 61
to test.AudioClipDetection
can crash the game when playing in 60 fps.Data 62
,Data 63
,Data 64
,Data 65
to test.Data 66
,Data 67
to test. These are just two motion blur example spots.PS2CameraSpeed
moves twice as fast (too fast).Data 70
to test.Data 70
to test.Data 1
to test Flesh Lips. Load save fileData 2
to test Abstract Daddies. Load save fileData 3
to test Final Boss.Other
Data 68
to test.Data 69
to test.Data 57
to test. Defeat Pyramid Head to make water drain.Data 4
to test. Go in the elevator and go to the Basement (B) Floor.FMVs
<path-to-game>\sh2e\movie\
, make a backup oftoilet.bik
, then replace it with this test 60 fps version. You can easily test this FMV by starting a new game or by watching "James in the Restroom" through the game's "MOVIE" menu found on the title screen.To help visualize the to-do list a bit easier:
AudioClipDetection
can crash the game when playing in 60 fps.PS2CameraSpeed
moves twice as fast (too fast).The text was updated successfully, but these errors were encountered: