Tab components #10
Merged
Tab components #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2017 15:23
|
You can see a demo of LabeledTabs and a demo of Tabs used for navigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full text of the proposal
This proposes the creation of a family of tab UI components:
Tabs. A set of tabbed panels that can be navigated by selecting corresponding tab buttons (which must be supplied by the developer).LabeledTabs. A specialized Tabs instance that presents simple tab buttons with text labels.TabStrip. A row or column of tab buttons. Responsible for positioning the buttons, handling keyboard navigation, and supporting accessibility.TabStripWrapper. Adds a TabStrip to a base element, wiring the selection states of the two together. For example, the Tabs component uses TabStripWrapper to connect a TabStrip to a Modes instance.LabeledTabButton. A classic rounded tab button showing a text label for a tab panel. This is used internally by LabeledTabs for its tab buttons.This RFC also includes the following mixins and helpers:
renderArrayAsElements. Helper function to render one element for each item in an array.ShadowReferencesMixin. Exposes a $ member on a component that references the elements in its shadow subtree, similar to Polymer's $ feature.