Change mode attribute to array in Measurements #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- closes elixir-bench#32 Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
tallysmartins
force-pushed
the
changes_in_measurements
branch
from
4d45d08
to
b430af1
Compare
PragTob
reviewed
Jul 3, 2018
| change(changeset, mode: [mode]) | ||
| else | ||
| changeset | ||
| end |
There was a problem hiding this comment.
we're not testing this functionality anywhere, are we?
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
PragTob
reviewed
Jul 10, 2018
| :std_dev_ips, | ||
| :std_dev_ratio | ||
| ] = Map.keys(changeset.changes) | ||
| end |
There was a problem hiding this comment.
not sure we need this test, we more or less just repeat the list of fields. We should be fine without it I think :)
There was a problem hiding this comment.
it doesn't cast the :mode attribute, the only field that is not required. But I agree that this is kind of a weak test, this case is someway covered in the next test cases where I do mode = nil. Will remove this.
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
tallysmartins
force-pushed
the
changes_in_measurements
branch
from
da300ec
to
3bacea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.