Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in Measurements required fields #38

Merged
merged 2 commits into from Jul 21, 2018
Merged

Changes in Measurements required fields #38

merged 2 commits into from Jul 21, 2018

Conversation

tallysmartins
Copy link
Member

We are not using this field for now, but I'm not sure if we should drop it from db/schema

@tallysmartins
Changes in Measurements required fields
f1cfa0c 
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited

Coverage Status

Coverage increased (+5.2%) to 84.314% when pulling 63b8e35 on tallysmartins:measurements-run-times into 978fb0a on elixir-bench:master.

@tallysmartins
Copy link
Member Author

tallysmartins commented Jul 18, 2018 •
edited

@PragTob I'm thinking if the test case that you suggested to be removed in the review of PR #33 we should be put back because a change like this would break the test build 🤔

PragTob
PragTob reviewed Jul 20, 2018
View reviewed changes
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a migration to also remove the field :)

@tallysmartins
Remove run times field from Measurements
63b8e35 
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
@tallysmartins
Copy link
Member Author

field removed

PragTob
PragTob approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@PragTob PragTob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@PragTob PragTob merged commit 16c9df6 into elixir-bench:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragTob PragTob PragTob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tallysmartins @coveralls @PragTob