Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistakes in DEVELOPMENT.md #160

Closed
josevalim opened this issue Nov 1, 2021 · 2 comments
Closed

Mistakes in DEVELOPMENT.md #160

josevalim opened this issue Nov 1, 2021 · 2 comments

Comments

@josevalim
Copy link
Contributor

Hi @kipcole9,

I am going through DEVELOPMENT.md and I believe it must be outdated in some places.

  1. export $CLDR_REPO must not have the $ character

  2. Some commands use MIX_ENV=gen but there is no such environment

  3. Step "Download the up-to-date ISO currency database" does not work at that moment. I have skipped it for now.

I will drop more comments/edit as I run into things.

@kipcole9
Copy link
Collaborator

kipcole9 commented Nov 1, 2021 via email

@josevalim
Copy link
Contributor Author

Beautiful, thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants