Fix spec for known_territory_subdivision
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schultzer
reviewed
Mar 8, 2024
`{:ok, nil}` is a valid response and not covered by the existing spec. Here I update the spec to account for this case.
There's an argument that maybe the library should return `{:ok, []}` when there are no known subdivisions for a valid territory. But as the `{:ok, nil}` was already the tested result I went with just updating the spec.
richard-ash
force-pushed
the
richard/update-known-subdivision-spec
branch
from
dd0134d
to
7f3cfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{:ok, nil}is a valid response and not covered by the existing spec. Here I update the spec to account for this case.There's an argument that maybe the library should return
{:ok, []}when there are no known subdivisions for a valid territory. But as the{:ok, nil}was already the tested result I went with just updating the spec.Reproduce: