Improved Crawly.fetch/2 to accept fetching with a spider #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziinc
changed the title
Ziinc
changed the title
|
Updated, tests passes on my side, should be ok to merge. |
|
Looks extremely good. The question is: "Can we move it outside of the main module? E.g. I want to shrink the crawly.ex" @Ziinc could you fix the test, alternatively, I can pick it up if you don't have time right now. |
|
We could move to |
* Add support of initial arguments Implemented as a part of #126 feature request * updated tests, added docs Co-authored-by: Ziinc <ty@tzeyiing.com>
|
Yeah. I have the same feelings. I was thinking of splitting parts related to Crawly from parts related to spiders into separate modules. Maybe it could make these modules small. In any case, can be done later on separately. Could you rebase it, so I will check again. |
|
@Ziinc I am about to cut off a new release. Could you please rebase this change, so I can include it as well? |
…/crawly into 52-improve-fetch-with-option
|
Done! |
oltarasenko
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #52, implements a
:withoption that allows the passing of the spider name.Breaking changes includes moving of the
headersandoptionsparameters to theoptsparameter, as keyword lists instead of positional args.