Add support of initial arguments #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented as a part of #126 feature request
Ziinc
requested changes
Nov 11, 2020
Ziinc
approved these changes
Nov 11, 2020
|
Have a glance at my changes, merge in if ok. |
oltarasenko
commented
Nov 11, 2020
oltarasenko
added a commit
that referenced
this pull request
Nov 13, 2020
* Added with option, moved all optional parameters to list opt * fixed failing test, added mock for settings override in mocked spider * added typespecs and docs * corrected typo in docs * remove doctest execution for Crawly module * Add support of initial arguments (#136) * Add support of initial arguments Implemented as a part of #126 feature request * updated tests, added docs Co-authored-by: Ziinc <ty@tzeyiing.com> * Added with option, moved all optional parameters to list opt * fixed failing test, added mock for settings override in mocked spider * added typespecs and docs * corrected typo in docs * remove doctest execution for Crawly module Co-authored-by: oltarasenko <oltarasenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as a part of #126 feature request