Patch 4 #1890
Closed
Patch 4 #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/elixir-ecto/ecto/blob/master/lib/mix/ecto.ex#L37 Although there would be no compilation error because of Mix.config/3 but it wouldn't result in a proper behaviour.
This would probably be helpful for someone like me, who never heard of embedded data models. Unfortunately, I couldn't find a DB-agnostic description (or maybe it runs by another name).
josevalim
reviewed
Jan 3, 2017
| @@ -355,7 +355,7 @@ defmodule Ecto do | |||
|
|
|||
| ### Embeds | |||
|
|
|||
| Ecto also supports embeds. While associations keep parent and child | |||
| Ecto also supports [embeds](https://docs.mongodb.com/manual/core/data-model-design/#data-modeling-embedding). While associations keep parent and child | |||
There was a problem hiding this comment.
Embeds are not specific to mongo, so I don't think we should link exclusively to mongo. :)
There was a problem hiding this comment.
Yeah, I had my concerns about that too but I couldn't find any DB-agnostic description of it (except for this one but I have too little experience to make sure that this is actually the same topic).
Thanks again and happy new year!
|
I have added one comment, thank you! |
josevalim
reviewed
Jan 4, 2017
| @@ -389,7 +389,7 @@ defmodule Ecto do | |||
| Ecto requires developers to specify the key `:ecto_repos` in their application | |||
| configuration before using tasks like `ecto.create` and `ecto.migrate`. For example: | |||
|
|
|||
| config :my_app, :ecto_repos, [MyApp.Repo] | |||
| config :my_app, ecto_repos: [MyApp.Repo] | |||
There was a problem hiding this comment.
Btw, those two calls are equivalent. Both would work. :)
|
Merged one commit manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for all the great work!