Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer contributor popovers #918

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented May 5, 2022

This PR will bring the same style and information from the contributor tiles in the overview page to the popovers at the bottom of each page:
Screenshot from 2022-05-05 16-08-00

@bedroesb bedroesb requested a review from martin-nc May 5, 2022 14:14
@bedroesb
Copy link
Member Author

bedroesb commented May 5, 2022

live preview here: https://bedroesb.github.io/rdmkit/data_transfer

Copy link
Member

@martin-nc martin-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I see the popover footer is a different colour in the Contributors' page but I think that's fine. You can't use the grey against the grey background of a "normal" page and the dark blue would be too much in the Contributors' page!

@bedroesb
Copy link
Member Author

bedroesb commented May 6, 2022

@martin-nc wow you summarized my struggle really well :D I also thought of a shade, but we don't use shades of our primary colour anywhere

@martin-nc
Copy link
Member

If you wanted to be absolutely consistent and have a grey footer in the popover, then a darker drop-shadow might distinguish it from the grey background. I'm not sure if it's necessary, though.

@bedroesb
Copy link
Member Author

bedroesb commented May 6, 2022

@martin-nc I took now the same drop shadow as the search dropdown, but yes you are right

@bedroesb
Copy link
Member Author

bedroesb commented May 6, 2022

I guess for now I leave it like this. it is an improvement. If it bothers me I make a new PR :)

@bedroesb bedroesb merged commit 4348aec into elixir-europe:master May 6, 2022
@bedroesb bedroesb deleted the nicer-contr branch August 21, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants