Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Xgit.Repository.InMemory: Remove a line of code that is unreachable. #245

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Nov 29, 2019

Changes in This Pull Request

I can't logically construct a way to get to this particular case, so why have it?

This returns Xgit to 100% code coverage.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented. n/a
  • There is test coverage for all changes. n/a
  • All cases where a literal value is returned use the cover macro to force code coverage. n/a
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

I can't logically construct a way to get to this particular case, so why have it?
@scouten scouten self-assigned this Nov 29, 2019
@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #245 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #245      +/-   ##
========================================
+ Coverage   99.92%   100%   +0.07%     
========================================
  Files          37     37              
  Lines        1325   1324       -1     
========================================
  Hits         1324   1324              
+ Misses          1      0       -1
Impacted Files Coverage Δ
lib/xgit/repository/in_memory.ex 100% <ø> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e513cb2...816550e. Read the comment docs.

@scouten scouten merged commit 44d7f99 into master Nov 29, 2019
@scouten scouten deleted the remove-unreachable-code branch November 29, 2019 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant