Changing File.exists? implementation.

Now using file:read_file_info() from Erlang.
elixir-lang · May 5, 2012 · 7a6a711 · 7a6a711
1 parent 4da2aaa
commit 7a6a711
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/file.ex b/lib/file.ex
@@ -30,17 +30,27 @@ defmodule File do
 
   @doc """
   Returns if `file` exists
+  This `file` can be regular file, directory, socket,
+  symbolic link, named pipe or device file.
 
   ## Examples
 
-    File.exists?("/tmp")
+    File.exists?("test/")
     #=> true
 
     File.exists?("missing.txt")
     #=> false
+
+    File.exists?("/dev/null")
+    #=> true
   """
   def exists?(filename) do
-    is_tuple(FL.last_modified(filename))
+    case F.read_file_info(filename) do
+    match: {:ok, _}
+      true
+    else:
+      false
+    end
   end
 
   @doc """

diff --git a/test/elixir/file_test.exs b/test/elixir/file_test.exs
@@ -35,6 +35,7 @@ defmodule FileTest do
   test :exists do
     assert File.exists?(__FILE__)
     assert File.exists?(File.expand_path("../fixtures/foo.txt", __FILE__))
+    assert File.exists?(File.expand_path("../fixtures/", __FILE__))
 
     refute File.exists?("fixtures/missing.txt")
     refute File.exists?("_missing.txt")