Logger handles :process_label from OTP27 #13392
Conversation
| {pid, crashed} = Keyword.pop_first(crashed, :pid) | ||
| {name, crashed} = Keyword.pop_first(crashed, :registered_name) | ||
| {{kind, reason, stack}, crashed} = Keyword.pop_first(crashed, :error_info) |
There was a problem hiding this comment.
I thought this should be semantically more robust to future changes, while still efficient enough popping from the head?
There was a problem hiding this comment.
Yeah this is totally fine, it's a really tiny list.
| {pid, crashed} = Keyword.pop_first(crashed, :pid) | ||
| {name, crashed} = Keyword.pop_first(crashed, :registered_name) | ||
| {{kind, reason, stack}, crashed} = Keyword.pop_first(crashed, :error_info) |
There was a problem hiding this comment.
Yeah this is totally fine, it's a really tiny list.
Sorry I am not sure what you mean. What I can think of is:
It would be a change of behavior but might make sense to include it, based on the doc from erlang/otp#7720:
|
|
Perfect, that's what needed to know then 👍 No need for extra tests 🙃 |
Awesome, thank you for confirming! |
OTP27 introduces a new
:process_labelkey between:registered_nameand:error_info(erlang/otp#7720), breaking the pattern-matching on the keyword-list:This PR just fixes the CI, but doesn't do anything with the label. We could maybe display it if
!= :undefined?