Logger logs :process_label if present #13396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Mar 6, 2024
whatyouhide
approved these changes
Mar 6, 2024
| @@ -530,6 +530,34 @@ defmodule Logger.TranslatorTest do | |||
| assert {%RuntimeError{message: "oops"}, [_ | _]} = process_metadata[:crash_reason] | |||
| end | |||
|
|
|||
| if :erlang.system_info(:otp_release) >= ~c"27" do | |||
There was a problem hiding this comment.
We got it too 🙃
Suggested change
| if :erlang.system_info(:otp_release) >= ~c"27" do | |
| if System.otp_release() >= "27" do |
There was a problem hiding this comment.
I like to do the following:
@tag skip: System.otp_release() < "27"(or if ..., do: @tag :skip.)
because it's less indent and less git diff when it's ultimately gonna be enabled. :)
There was a problem hiding this comment.
Oh that's neat! Thanks @whatyouhide @wojtekmach !
There was a problem hiding this comment.
We got it too 🙃
We need to tell Jose 😄
7291154
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
josevalim
reviewed
Mar 6, 2024
josevalim
approved these changes
Mar 6, 2024
Co-authored-by: José Valim <jose.valim@gmail.com>
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See erlang/otp#7720
Following #13392