Correctly Macro.escape :quote triplet without meta

[kristofka]

Attempts to solve #13593
Attempts to solve an issue that causes Macro.escape/2 to crash when
given certain tuples.

Note that, as discussed in the reported issue, Macro.escape({:quote, [column: 10], [:foo]}) still produces
: {:{}, [], [:quote, [], [:foo]]} which is arguably wrong.

[josevalim]

I think we should have the is_list check a bit higher. We should not even be attempting to keydelete it. We should possibly be adding is_list(Meta) to all clauses here in do_quote:

elixir/lib/elixir/src/elixir_quote.erl

Line 266 in 2cc4372

do_quote({quote, Meta, [Arg]}, Q) ->

[kristofka]

You are correct, this makes the intent cleaner. Unfortunately, I'm still unsure how to avoid passing something of the form {:quote, [column: :bar], [:foo]} . So far my attempts to restrict the match at the level of the first clause have failed.

[josevalim]

💚 💙 💜 💛 ❤️