-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide tab-completion for aliases #3280
Conversation
aliases = Enum.map(env_aliases(), fun) | ||
modules = | ||
Enum.map(:code.all_loaded(), fun) | ||
|> Enum.into(aliases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it clearer to make it aliases ++ Enum.map(...)
?
Thank you! I have added some comments! |
5861595
to
5b85140
Compare
Thanks for your comments.
note the lack of modules for |
d096cd4
to
27076c7
Compare
@josevalim this is ready for merge. Don't see a way to make tests for it (we can start IEx with predefined
|
Provide tab-completion for aliases
❤️ 💚 💙 💛 💜 |
Closes #2519.
It is based on
IEx.Server.whereis/0
usage, as there is no other way to reach current%IEx.State{}
.Probably we can use separate agent to track state, not sure if it worth it though; the current implementation might be OK for a first iteration.
I'd like to have any feedback or suggestions ot it. Just for reference: #2519 (comment).
This also makes possible to add tab-completion for user imports.