Add NFC support to String.normalize/2 #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanenders
force-pushed
the
add-string-normalize-nfc
branch
4 times, most recently
from
1e29ba4
to
d46fd78
Compare
| @@ -482,4 +496,50 @@ defmodule String.Normalizer do | |||
| end | |||
|
|
|||
| defp combining_class(_), do: 0 | |||
|
|
|||
| def nfd_to_nfc("", acc), do: acc | |||
There was a problem hiding this comment.
Should those functions be private. :)
There was a problem hiding this comment.
Good catch! The irony is that I added syntax support for distinguishing private functions from public ones in Sublime Text, but I never bothered to utilize that distinction in my color scheme. 😆
|
@endersstocker curiosity, can you tell me how big is the String.Normalizer.beam in KB after this PR? |
|
168 KiB / 172 KB |
|
@josevalim I’ve optimized it to normalize NFC in a single pass. |
bryanenders
force-pushed
the
add-string-normalize-nfc
branch
5 times, most recently
from
da81896
to
70c65f9
Compare
| part = :binary.part(binary, 0, n) | ||
| case n do | ||
| 1 -> normalize_nfc(rest, acc <> part) | ||
| _ -> normalize_nfc(rest, acc <> compose(normalize(part, :nfd))) |
There was a problem hiding this comment.
let's call normalize_nfd(..., "")
|
This is great. I have added a tiny comment. Can you please address it and squashh your changes? ❤️ |
bryanenders
force-pushed
the
add-string-normalize-nfc
branch
2 times, most recently
from
c11e090
to
4a42861
Compare
bryanenders
force-pushed
the
add-string-normalize-nfc
branch
from
4a42861
to
07fedf6
Compare
|
It’s good to go. |
josevalim
added a commit
that referenced
this pull request
Oct 4, 2015
Add NFC support to String.normalize/2
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.