Improve error when using non-arith guard BIF in match

[fishcakez]

Only arith BIFs are allowed in matches.

Partial fix for #5666.

[whatyouhide]

I know the rest of the file is like this so that might be the reason, but why are we using ;s here instead of:

case [] do :erlang.make_ref() -> :ok end

Is there a specific reason or just No Particular Reason™?

[fishcakez]

That's what rest of file did? More importantly messed up guard tests from lazy copy paste.

…

On 17 Jan 2017 4:44 pm, "Andrea Leopardi" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/elixir/test/elixir/kernel/errors_test.exs <#5667 (review)> : > @@ -925,6 +925,22 @@ defmodule Kernel.ErrorsTest do 'case [] do; [] when Hello.something_that_does_not_exist == [] -> :ok; end' end + test "invalid :erlang call on match" do + assert_compile_fail CompileError, + "nofile:1: cannot invoke remote function :erlang.make_ref/0 inside match", + 'case [] do; :erlang.make_ref() -> :ok; end' + + assert_compile_fail CompileError, + "nofile:1: cannot invoke remote function :erlang.self/0 inside match", + 'case [] do; self() -> :ok; end' + end + + test "invalid :erlang call on guard" do + assert_compile_fail CompileError, + "nofile:1: cannot invoke remote function :erlang.make_ref/0 inside match", + 'case [] do; :erlang.make_ref() -> :ok; end' I know the rest of the file is like this so that might be the reason, but why are we using ;s here instead of: case [] do :erlang.make_ref() -> :ok end Is there a specific reason or just No Particular Reason™? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5667 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB6JTVCZENHwdE-leSUa7hymKfp3TcUBks5rTO_CgaJpZM4Ll1Mj> .

[whatyouhide]

That's what rest of file did?

Yup, I suspected this :)

[fishcakez]

Yup, I suspected this :)

Would you like to change it?

[whatyouhide]

@fishcakez We can change it on the whole file after this if we care about this, for this PR I think we're ok sticking with what's in the file. Wdyt?

[fishcakez]

@whatyouhide ok, I have fixed the guard test.