Unify formatting of some common expansion errors #5797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors can now be formatted via either elixir_expand:format_error/1 or elixir_clauses:format_error/1.
lexmag
reviewed
Feb 20, 2017
lib/elixir/src/elixir_clauses.erl
Outdated
| format_error(missing_do_or_after_in_receive) -> | ||
| "missing do or after keyword in receive"; | ||
| "missing :do or :after in \"receive\""; | ||
|
|
||
| format_error(missing_keyword_in_try) -> |
There was a problem hiding this comment.
Great catch. Was thinking, what if we unify this error as well and have something like
format_error({missing_options, Kind, Opts}) ->
StringOpts = 'Elixir.Enum':map_join(Opts, <<"/">>, fun 'Elixir.Macro':to_string/1),
io_lib:format("missing ~ts in \"~ts\"", [StringOpts, Kind]);Wdyt? We would unify try and receive as well this way.
There was a problem hiding this comment.
I believe Elixir.Enum won't be available on that step, we could use Erlang alternative.
I think it makes sense to unify like that. 👍
There was a problem hiding this comment.
We can also perhaps generalize missing_do to missing_option?
There was a problem hiding this comment.
@lexmag definitely, that's what I meant. :)
josevalim
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors can now be formatted via either
elixir_expand:format_error/1orelixir_clauses:format_error/1.