Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the cwd for system calls in the git scm #8279

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Set the cwd for system calls in the git scm #8279

merged 1 commit into from
Nov 6, 2018

Conversation

mobileoverlord
Copy link
Contributor

The Git SCM doesn't function properly when running under a slave node because the current working directory is pulled from the master instead of the current slave node. This PR updates calls to System.cmd/3 to set the current working directory.

@mobileoverlord
Copy link
Contributor Author

I've done further testing with running mix inside a slave node and this appears to be the only stumbling point that I have found. I have updated this to address the comments.

@josevalim josevalim merged commit 2d97460 into elixir-lang:master Nov 6, 2018
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobileoverlord @josevalim