657 properly set link in types with parameter #694
Conversation
link to parameterized types in parens
|
Hello, @ymtszw! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixir-lang/ex_doc/pulls/694. |
| @@ -179,6 +181,13 @@ defmodule ExDoc.Formatter.HTML.Autolink do | |||
| end | |||
| defp strip_parens(string, _), do: string | |||
|
|
|||
| defp split_string_to_link(string) do | |||
| case :binary.match(string, "(") do | |||
There was a problem hiding this comment.
Use :binary.split and then you don't need to use match+String.split_at. :)
There was a problem hiding this comment.
0c851c6 here it is.
I thought it should be OK here to exact-match against 2- or 1-element lists, correct?
There was a problem hiding this comment.
^ sorry, alt account
|
I have added one tiny comment and this is good to go! Thank you! |
|
❤️ 💚 💙 💛 💜 |
Should fix #657