Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception from Logger when running on a 1.10 project #107

Closed
axelson opened this issue Jan 28, 2020 · 0 comments · Fixed by #109
Closed

Exception from Logger when running on a 1.10 project #107

axelson opened this issue Jan 28, 2020 · 0 comments · Fixed by #109

Comments

@axelson
Copy link
Member

axelson commented Jan 28, 2020 

07:00:03.587 [error] GenServer ElixirLS.LanguageServer.Server terminating
** (UndefinedFunctionError) function Logger.__should_log__/1 is undefined or private
    (logger 1.10.0) Logger.__should_log__(:warn)
    (language_server 0.2.28) lib/language_server/server.ex:164: ElixirLS.LanguageServer.Server.handle_info/2
    (stdlib 3.10) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib 3.10) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib 3.10) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

Note: this doesn't affect the vscode extension because the vscode extension doesn't hit this code path because it usually supplies a workspace/didChangeConfiguration message.
@axelson axelson mentioned this issue Jan 28, 2020
Merged
axelson added a commit that referenced this issue Jan 30, 2020
@axelson
Replace Logger.warn with JsonRpc warning (#109)
d8277fa 
On Elixir 1.10 `Logger.__should_log__/1` has been removed which causes an
exception. This shows that we should look at alternative mechanisms to run
elixir-ls that will always run it under the elixir version that it was initially
compiled with.

Fixes #107
@axelson axelson mentioned this issue Feb 7, 2020
Closed
axelson added a commit that referenced this issue Jun 14, 2020
@axelson
Update changelog for vscode #107
bde365d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Logger.warn with JsonRpc warning
1 participant
@axelson