Replace Logger.warn with JsonRpc warning #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Elixir 1.10 `Logger.__should_log__/1` has been removed which causes an exception. This shows that we should look at alternative mechanisms to run elixir-ls that will always run it under the elixir version that it was initially compiled with. Fixes #107
|
How was that causing a problems? I cannot deduce that from the PR |
|
Discussed this in the elixir slack, but the issue happens when you compile elixir-ls under 1.9 (or lower) and then run it on 1.10 (which has removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Elixir 1.10
Logger.__should_log__/1has been removed which causes an exception. This shows that we should look at alternative mechanisms to run elixir-ls that will always run it under the elixir version that it was initially compiled with.Fixes #107