Ensure build is complete before finishing tests #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelson
reviewed
Mar 12, 2021
| @@ -937,6 +937,8 @@ defmodule ElixirLS.LanguageServer.ServerTest do | |||
|
|
|||
| # File is already formatted | |||
| assert response(3, []) == resp | |||
|
|
|||
| wait_until_compiled(server) | |||
There was a problem hiding this comment.
Instead of adding these to each individual test directly, could we add it to a generic setup block? Perhaps one that checks for fixture: true. That would make it harder to miss one of these in the future.
There was a problem hiding this comment.
I tried adding it in on_exit callback but the server process is already down when it's executed. We'd need wrapping it in a lambda or macro with do block.
axelson
added a commit
to axelson/elixir-ls
that referenced
this pull request
Mar 14, 2021
axelson
added a commit
that referenced
this pull request
Mar 28, 2021
* Add changelog test to verify that the changelog is correctly linked * Update changelog * Add #497 * Specify that the fuzzy completion is only for functions * Fix formatting * update changelog for #505 * Update changelog for #501, #473, and #504 * Update changelog for #507 and vscode #176 * Update changelog for #511 * Update changelog for #492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495