-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EXLA Client to use PjRt #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors EXLA to use PjRt. Once merged this will accomplish multiple things:
BlockHostUntilReady
, which will make resolving Introduce Nx.Stream #200 much easierAs is, fails all async tests on CPU; however, we may want to consider adjusting how async works considering how much simpler this makes things. It also fails two op tests: QR Decomposition and Window Max. I'm investigating whether or not this might be an upstream issue.
Fails most tests on TPU. This is an issue with the executable not liking the layout of our input buffers. I've been talking with some of the PjRt developers about this issue.
Yet to test on GPU, but I don't think there will be any major hiccups.
I will need to adjust our Makefile to try and get rid of the NumPy dependency before this is merged.