Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hooks and tokens for Nx #558

Merged
merged 11 commits into from
Nov 23, 2021
Merged

Implement hooks and tokens for Nx #558

merged 11 commits into from
Nov 23, 2021

Conversation

josevalim
Copy link
Collaborator

  • All implementation for Nx is here, including grad and evaluator, only tests are pending
  • Implementation for EXLA will be in another pull request
  • inspect_value/2 is also included for your debugging enjoying

josevalim
josevalim commented Nov 23, 2021
View reviewed changes
nx/lib/nx/defn/kernel.ex Outdated Show resolved Hide resolved
josevalim and others added 2 commits November 23, 2021 21:40
@josevalim @polvalente
Apply suggestions from code review
af84378 
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@josevalim
Validate options
3eea77a
josevalim and others added 3 commits November 23, 2021 22:53
@josevalim
Evaluator tests
ea78d42
@josevalim
Unit tests for Nx.Defn.Kernel
608b8b4
@josevalim @jonatanklosko @polvalente
Apply suggestions from code review
e1ba155 
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
@josevalim josevalim merged commit 8d4e9da into main Nov 23, 2021
@josevalim josevalim deleted the jv-tokens branch November 23, 2021 22:21
@josevalim
Copy link
Collaborator Author

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polvalente polvalente polvalente left review comments

@jonatanklosko jonatanklosko jonatanklosko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josevalim @polvalente @jonatanklosko